inconsistent reporting of ^Enter

[pm100]

on version 0.18 with raw mode enabled

If I type Ctrl+Enter

• on windows I get Key = enter, mods = ctrl
• on linux I get key = j, Mods = ctrl

The linux one seems wrong

[pm100]

test app - using doc sample

use crossterm::event::{read, Event};

fn print_events() -> crossterm::Result<()> {
    loop {
        // `read()` blocks until an `Event` is available
        match read()? {
            Event::Key(event) => println!("{:?}", event),
            Event::Mouse(event) => println!("{:?}", event),
            Event::Resize(width, height) => println!("New size {}x{}", width, height),
        }
    }
    Ok(())
}

fn main(){
    crossterm::terminal::enable_raw_mode();
    print_events();
}

run this on linux and go ctrl+enter

on windows

note, on linux ctrl+j is also reported as ctrl+j

[imsnif]

Can confirm, same here.

[imsnif]

Found the issue. For me this happened because of this line: https://github.com/crossterm-rs/crossterm/blob/master/src/event/sys/unix/parse.rs#L76

I was in raw mode, but didn't use crossterm to enter raw mode (I was using tcsetattr from termios). Crossterm was checking its own internal state to see whether I was in raw mode and that's why this issue happened.

EDIT: to fix this, I used crossterm::terminal::enable_raw_mode instead nof the tcsetattr.

[TimonPost]

@pm100 I tried it on a tmate terminal and I don't seem to get the CTRL + J, but the ENTER without CTRL. Perhaps you can trie what @imsnif proposed?

[pm100]

@TimonPost what is he suggesting? In my code I used what he suggests

[TimonPost]

Enabling raw modes? What terminal are you using on Linux?

[TimonPost]

Closing in favor of #685.