Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Hash for more style types #942

Open
markus-bauer opened this issue Nov 14, 2024 · 1 comment
Open

Derive Hash for more style types #942

markus-bauer opened this issue Nov 14, 2024 · 1 comment

Comments

@markus-bauer
Copy link

Color derives Hash:

#[derive(Copy, Clone, Debug, PartialEq, Eq, Ord, PartialOrd, Hash)]
pub enum Color {

But most others don't:

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub struct Colors {

#[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
pub struct Attributes(u32);

...etc.

Can you add this, or is this by design?

@markus-bauer markus-bauer changed the title Derive Hash for mor style types Derive Hash for more style types Nov 14, 2024
@joshka
Copy link
Collaborator

joshka commented Nov 22, 2024

Seems like a reasonable thing to add. Can you submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants