Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update Channel Rewards based Sort Tags not working #2861

Open
1 task done
arblane opened this issue Oct 16, 2024 · 5 comments
Open
1 task done

[Bug] Update Channel Rewards based Sort Tags not working #2861

arblane opened this issue Oct 16, 2024 · 5 comments
Labels
Bug A defect in the app Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release

Comments

@arblane
Copy link

arblane commented Oct 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Updating the Channel Reward Pause state is not peforming as expected.

Expected Behavior

Channel Rewards with tag 'SFX' should be updated with the set value of Pause/UnPaused.

Steps To Reproduce

  1. Create or use existing Channel Reward (Firebot created).
  2. Add a tag, 'SFX' for example.
  3. Create Preset Effect List that Updates Channel Reward by Sort Tag ('SFX') and Update Paused value is set to 'Pause'.
  4. Save and Test Preset Effect List

Version

5.63.2 and firebot-v5.63.2-nightly.24.10.03

What operating system are you using Firebot on?

Windows 11

Relevant log output

[2024-10-16 18:23:47.0036] - info: [v5.63.2] DBG: [Oct 16th 2024 2:23 pm] Toggle CPR - Disabled
[2024-10-16 18:23:47.0040] - error: [v5.63.2] Unhandled promise rejection 
{
  message: "Cannot read properties of undefined (reading 'includes')",
  stack: "TypeError: Cannot read properties of undefined (reading 'includes')\n" +
    '    at C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\effects\\builtin\\update-channel-reward.js:271:47\n' +
    '    at Array.filter (<anonymous>)\n' +
    '    at Object.onTriggerEvent (C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\effects\\builtin\\update-channel-reward.js:271:14)\n' +
    '    at C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:89:40\n' +
    '    at new Promise (<anonymous>)\n' +
    '    at triggerEffect (C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:68:12)\n' +
    '    at C:\\Users\\muskr\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:147:40'
}

Contact Details (Optional)

arblane

@arblane arblane added the Bug A defect in the app label Oct 16, 2024
@github-project-automation github-project-automation bot moved this to Todo in Firebot Oct 16, 2024
@arblane
Copy link
Author

arblane commented Oct 16, 2024

The same behavior appears to be occurring for Disable/Enable updates.

@arblane
Copy link
Author

arblane commented Oct 16, 2024

image

@CKY-
Copy link
Collaborator

CKY- commented Oct 16, 2024

Who Owns SFX?

@arblane
Copy link
Author

arblane commented Oct 16, 2024

image

@arblane
Copy link
Author

arblane commented Oct 16, 2024

Changed Hydrate and Posture Check tags from 'SFX' to 'CPR' for testing, to avoid collision with unmanaged shared tag with Quack. Same result of not updating Channel Reward and logged unhandled promise rejection.

dennisrijsdijk added a commit to dennisrijsdijk/Firebot that referenced this issue Oct 18, 2024
@dennisrijsdijk dennisrijsdijk added Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review. labels Oct 18, 2024
CaveMobster pushed a commit that referenced this issue Oct 21, 2024
* fix: reward missing sort tags throws error (#2861)

* fix: command missing sort tags throws error (#2787)

* fix: time based missing sort tag throws error
@dennisrijsdijk dennisrijsdijk added Release Pending Issue has been resolved and is waiting to be packaged as part of a release and removed Ready For Review Issue has a PR opened and is undergoing dev review. labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release
Projects
Status: Todo
Development

No branches or pull requests

3 participants