-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static code analysis. #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n valid until everything is released.
crud89
force-pushed
the
code-analysis
branch
from
December 12, 2024 09:28
bcd490a
to
af8ce89
Compare
crud89
force-pushed
the
code-analysis
branch
2 times, most recently
from
December 12, 2024 17:59
2d4b48a
to
fb33e9a
Compare
crud89
force-pushed
the
code-analysis
branch
from
December 13, 2024 09:24
fb33e9a
to
2f24532
Compare
crud89
force-pushed
the
code-analysis
branch
from
December 13, 2024 10:34
573890d
to
65670d9
Compare
This prevents errors to be created for warnings, but we don't care for testing (that's what we have the tidy step for).
Run: checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR adds
clangcl
presets that are intended to be used during CI for static code analysis usingclang-tidy
. From now on, each PR executes checks against static code analysis and automated tests (see #129). Alongside this, lots of issues with the code base have been addressed. Most importantly:SharedObject
base class for objects that enableshared_from_this
. This also allows for more efficient allocation of shared pointers, so it's the recommended way to implement objects that require shared ownership.WeakPtr
to their parent device instead of a reference. This way, it was possible to catch several issues where resource release must happen in order to prevent invalid memory access.pImpl
pointers has changed and theImplements
base (which was never really helpful anyway) has been removed.