Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback errors when trying to play embedded video in lab_demo in VS Code desktop on macOS #16

Open
dmalan opened this issue Sep 10, 2022 · 7 comments
Open

Playback errors when trying to play embedded video in lab_demo in VS Code desktop on macOS #16

dmalan opened this issue Sep 10, 2022 · 7 comments
Assignees
@rongxin-liu
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@dmalan
Copy link
Member

dmalan commented Sep 10, 2022

Screen Shot 2022-09-09 at 8 46 57 PM
@dmalan dmalan added the bug Something isn't working label Sep 10, 2022
@dmalan dmalan changed the title Do you get playback errors when trying to play embedded video in lab_demo? Do you get playback errors when trying to play embedded video in lab_demo in VS Code desktop on macOS? Sep 10, 2022
@rongxin-liu
Copy link
Contributor

Not a bug or maybe a VS Code bug. I can't get it work on VS Code Desktop version but works ok on Codespace.

@dmalan
Copy link
Member Author

dmalan commented Sep 10, 2022

Mind checking what audio and video codecs that video uses?

@rongxin-liu
Copy link
Contributor

rongxin-liu commented Sep 10, 2022 •
edited
Loading

VP09 / OPUS
Screen Shot 2022-09-09 at 20 54 22

@rongxin-liu
Copy link
Contributor

rongxin-liu commented Sep 10, 2022 •
edited
Loading

YouTube playback issue: microsoft/vscode#158858
MP4 playback issue: microsoft/vscode#158972

@dmalan dmalan changed the title Do you get playback errors when trying to play embedded video in lab_demo in VS Code desktop on macOS? Playback errors when trying to play embedded video in lab_demo in VS Code desktop on macOS Sep 10, 2022
@dmalan
Copy link
Member Author

dmalan commented Sep 10, 2022 •
edited
Loading

Just to close the loop here, possible for us (or VS Code) to compel the player to fall back on H.264 instead somehow, as in your browser-based tests a while back? Possible to simulate, perhaps, by executing a command in VS Code's developer console?

@rongxin-liu
Copy link
Contributor

Not possible from my experiment. Had tried injecting these codes in our lab.js script to suppress VP09 but no luck.

Best to have VS Code support VP09/OPUS codec.

@rongxin-liu
Copy link
Contributor

rongxin-liu commented Sep 10, 2022 •
edited
Loading

I also tried playing back our mp4 file from the CDN, but no audio it seems. I think this is because all our videos use aac codec for the audio, but VS Code desktop doesn't support this codec. Not sure why such popular/basic aac codec is not supported.

microsoft/vscode#158972

@rongxin-liu rongxin-liu added the help wanted Extra attention is needed label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rongxin-liu rongxin-liu

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmalan @rongxin-liu