Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get player's active match #48

Open
cameronshinn opened this issue Apr 5, 2020 · 3 comments
Open

Cannot get player's active match #48

cameronshinn opened this issue Apr 5, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@cameronshinn
Copy link
Member

Describe the bug
getPlayerMatchByDiscordId() returns 404

To Reproduce
Steps to reproduce the behavior:

  1. Start a match by filling up the queue
  2. Query /player/discord/{discordId}/match for one of the players in the match
    • We did this before everyone joined the server

Additional context
We suspect something is wrong with the DB query here.

@cameronshinn cameronshinn added the bug Something isn't working label Apr 5, 2020
@B3none
Copy link
Member

B3none commented Apr 5, 2020

If you did it before they joined the server then they won’t be in the players_matches table.

@cameronshinn
Copy link
Member Author

cameronshinn commented Apr 5, 2020

We did it while @Shaneajm was in the server and the query didn't return anything on his end. Note that this was before the match started since I wasn't in the server.

@cameronshinn
Copy link
Member Author

Also we think this should work in the same instances where InMatch (of the player object) returns true. That means it should return a match is the player hasn't joined it yet. This way it can be used for the future team drafting integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants