NEWS and CRAN comments

cynkra · Feb 11, 2023 · f2be50f · f2be50f
1 parent ecdee5e
commit f2be50f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 142 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -2,149 +2,45 @@
 
 # dm 1.0.4
 
-## Chore
-
-- Make sure `{dm}` passes "noSuggests" workflow (#1659).
-
-
-# dm 1.0.3.9011
-
-## Documentation
-
-- Update pkgdown URL (#1652).
-
-
-# dm 1.0.3.9010
-
-## Chore
-
-- Fix r-devel builds (#1776).
-
-- Establish compatibility with dplyr 1.1.0 (#1771).
-
-## Testing
-
-- Restore database checks on GHA (#1751).
-
-
-# dm 1.0.3.9009
-
 ## Features
 
-- Breaking change: `dm_get_all_pks()`, `dm_get_all_fks()`, and `dm_get_all_uks()` require unquoted table names as input, for consistency with other parts of the API (#1741).
-
-## Breaking changes
-
-- Breaking change: `dm_get_all_pks()`, `dm_get_all_fks()`, and `dm_get_all_uks()` require unquoted table names as input, for consistency with other parts of the API (#1741).
-
-
-# dm 1.0.3.9008
-
-- Internal changes only.
-
-
-# dm 1.0.3.9007
-
-## Features
+- `dm_add_pk()` gains `autoincrement` argument (#1689), autoincrement primary keys are configured on the database with `copy_dm_to()` (#1696).
 
 - New `dm_add_uk()`, `dm_rm_uk()` and `dm_get_all_uks()` functions for explicit support of unique keys (#622, #1716).
 
+- `dm_get_all_pks()` and `dm_get_all_fks()` return output in the order of `table` or `parent_table` argument (#1707).
 
-# dm 1.0.3.9006
-
-## Bug fixes
-
-- Correct error message if nonexisting table is passed to `dm_get_all_pks()` (#1740).
-
-
-# dm 1.0.3.9005
-
-## Continuous integration
-
-- Avoid oldrel-4.
-
-
-# dm 1.0.3.9004
-
-- Internal changes only.
-
-
-# dm 1.0.3.9003
-
-- Internal changes only.
+- Improve error message for `dm_add_pk()` when the `columns` argument is missing (#1644, #1646).
 
+## Breaking changes
 
-# dm 1.0.3.9002
+- `dm_get_all_pks()`, `dm_get_all_fks()`, and `dm_get_all_uks()` require unquoted table names as input, for consistency with other parts of the API (#1741).
 
 ## Bug fixes
 
 - `dm_examine_constraints()` works for `dm` objects on the database with compound keys (#1713).
 
-## Chore
-
-- `dm_unpack_tbl()` sets PK before FK (#1715).
-
-- Clean up `dm_rows_append()` implementation (#1714).
-
-
-# dm 1.0.3.9001
-
-## Features
-
-- `dm_get_all_pks()` and `dm_get_all_fks()` keep order of `table` or `parent_table` argument (#1707).
-
-- Support AI PKs for dm_copy_to() for empty tables (ptype) (#1696).
-
-- Adapt dm structure to support autoincrement PKs (#1689).
-
-- Improve error message for `dm_add_pk()` when the `columns` argument is missing (#1644, #1646).
-
-## Chore
-
-- Accept dm tables that are tbl_sql but not tbl_dbi (#1695, #1710).
-
-- Use correctly typed missing value for lists (@DavisVaughan, #1686).
-
-- Require lifecycle >= 1.0.3 (#1637).
-
-## Continuous integration
-
-- Use `--no-multiarch` for Windows 3.6 tests.
-
-- Remove duplicate step in validate GHA (#1694).
-
 ## Documentation
 
-- Fix link rot (#1671).
-
-## Uncategorized
-
-- Merge pull request #1698 from cynkra/1642-f-autoincrement-dm-rows-append.
-
-
-
-- Merge pull request #1640 from cynkra/docs-cynkra-pkgdown.
-
-
+- Update pkgdown URL to <https://dm.cynkra.com/> (#1652).
 
-- Harmonize yaml formatting.
-
-- Revert changes to matrix section.
-
-- Merged cran-1.0.3 into main.
+- Fix link rot (#1671).
 
+## Internal
 
+- Require dplyr >= 1.1.0 and lifecycle >= 1.0.3 (#1771, #1637).
 
-# dm 1.0.3.9000
+- Checks pass if all suggested packages are missing (#1659).
 
-## Chore
+- Fix r-devel builds (#1776).
 
-- Avoid running example without database connection.
+- `dm_unpack_tbl()` sets PK before FK (#1715).
 
-## Uncategorized
+- Clean up `dm_rows_append()` implementation (#1714).
 
-- Merged cran-1.0.2 into main
+- `dm()` accepts tables that are of class `"tbl_sql"` but not `"tbl_dbi"` (#1695, #1710).
 
+- Use correctly typed missing value for lists (@DavisVaughan, #1686).
 
 
 # dm 1.0.3

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,28 +1,7 @@
 dm 1.0.4
 
-## Cran Repository Policy
-
-- [x] Reviewed CRP last edited 2022-07-26.
-
-## R CMD check results
-
-- [x] Checked locally, R 4.2.2
-- [ ] Checked on CI system, R 4.2.2
-- [ ] Checked on win-builder, R devel
-
-Check the boxes above after successful execution and remove this line. Then run `fledge::release()`.
-
 ## Current CRAN check results
 
 - [x] Checked on 2023-02-11, problems found: https://cran.r-project.org/web/checks/check_results_dm.html
-- [ ] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64
-- [ ] ERROR: r-devel-linux-x86_64-debian-clang
-- [ ] ERROR: r-devel-linux-x86_64-debian-gcc
-- [ ] ERROR: r-devel-linux-x86_64-fedora-clang
-- [ ] ERROR: r-devel-linux-x86_64-fedora-gcc
-- [ ] ERROR: r-devel-windows-x86_64
-- [ ] ERROR: r-patched-linux-x86_64
-- [ ] ERROR: r-release-linux-x86_64
-- [ ] ERROR: r-oldrel-windows-ix86+x86_64
-
-Check results at: https://cran.r-project.org/web/checks/check_results_dm.html
+- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64: Fixed
+- [x] ERROR: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64, r-patched-linux-x86_64, r-release-linux-x86_64, r-oldrel-windows-ix86+x86_64: Fixed