Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(deps): update ct docker image to cypress/browsers:node-18.20.3 #473

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Jul 16, 2024

Issue

The CircleCI workflow .circleci/test-deploy.yml is configured to use the Docker container:

cypress/browsers:node-16.18.1-chrome-109.0.5414.74-1-ff-109.0-edge-109.0.1518.52-1

for component testing of examples/angular-app.

Node.js 16 already reached end-of-life on Sep 11, 2023 and is no longer supported.

Compatibility constraints

Change

Update the Docker container used for component testing in .circleci/test-deploy.yml from

  • cypress/browsers:node-16.18.1-chrome-109.0.5414.74-1-ff-109.0-edge-109.0.1518.52-1

to

  • cypress/browsers:node-18.20.3-chrome-125.0.6422.141-1-ff-126.0.1-edge-125.0.2535.85-1

This Cypress Docker image contains:

  • Node.js 18.20.3
  • Chrome 125.0.6422.141-1
  • Firefox 126.0.1
  • Edge 125.0.2535.85-1

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399
Copy link
Collaborator Author

Verification

Local current browsers

On Ubuntu 22.04.4 LTS with Node.js 18.20.3

cd examples/angular-app
npm ci
npx cypress run --component
npx cypress run --component --browser chrome
npx cypress run --component --browser edge
npx cypress run --component --browser firefox

Local Docker

docker run -it --rm -v .:/e2e -w /e2e cypress/browsers:node-18.20.3-chrome-125.0.6422.141-1-ff-126.0.1-edge-125.0.2535.85-1

Tests as above.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 17, 2024 05:29
@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 marked this pull request as draft July 17, 2024 07:51
@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 18, 2024 04:27
@jennifer-shehane jennifer-shehane merged commit cc4944d into cypress-io:master Jul 18, 2024
7 of 8 checks passed
@MikeMcC399 MikeMcC399 deleted the update/ct-docker branch July 19, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleCI test-deploy workflow uses end-of-life Node.js 16
3 participants