Workflow failure after orb-tools update to v12 PR #469

[MikeMcC399]

Issue

• The merge of PR chore(deps): update dependency orb-tools to v12 #469 into the master branch fails to run the workflow .circleci/test-deploy.yml

https://app.circleci.com/pipelines/gh/cypress-io/circleci-orb/1945 shows

Error calling workflow: 'test-deploy'
Error calling job: 'orb-tools/publish'
Missing required argument(s): orb_name, vcs_type

Renovate has only updated

circleci-orb/.circleci/test-deploy.yml

Line 4 in bd1d323

orb-tools: circleci/orb-tools@12.1.0

and has left

circleci-orb/.circleci/config.yml

Line 4 in bd1d323

orb-tools: circleci/orb-tools@11.6.1

unchanged.

The v12 Migration Guide provides the full set of instructions for migration.

See also https://discuss.circleci.com/t/orb-tools-v12-test-without-publishing/48014

Suggestion

• revert PR chore(deps): update dependency orb-tools to v12 #469

Following the above v12 Migration Guide introduces serious breaking changes, since the dash (-) character is converted to underscore (_) everywhere. It would need to be considered whether a migration to orb-tools v12 is necessary and how it should be done to minimize user impact.

[MikeMcC399]

• A failed attempt was made through PR chore(deps): update config.yml to orb-tools 12.1.0 #477

[MikeMcC399]

After trying out the migrate.sh script I realized that this is not a simple update and it is not something that I would want to attempt myself.

The script introduces serious breaking changes, since the dash (-) character is converted to underscore (_) everywhere (even in places it shouldn't, like for wait-on), so if this were to be implemented it would need a v4 release of the cypress-io/circleci-orb.

• The best short-term solution is to simply revert PR chore(deps): update dependency orb-tools to v12 #469. I have submitted this as PR Revert "chore(deps): update dependency orb-tools to v12 (#469)" #478.

[jennifer-shehane]

Yah, unfortunate