Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency orb-tools to v12 #479

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 17, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
orb-tools orb major 11.6.1 -> 12.1.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@cypress-app-bot
Copy link
Collaborator

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@MikeMcC399
Copy link
Collaborator

@renovate renovate bot force-pushed the renovate/orb-tools-12.x branch from 4192217 to eb59cf6 Compare July 18, 2024 17:08
@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Jul 19, 2024

Orb Tools 12, released in May 2023, changed all parameters to "snake case", meaning that dash (-) changes to underscore (_)
https://discuss.circleci.com/t/orb-tools-v12-test-without-publishing/48014
https://circleci.com/developer/orbs/orb/circleci/orb-tools
https://github.com/CircleCI-Public/orb-tools-orb

So, for instance in .circleci/config.yml

- orb-tools/publish:
orb-name: cypress-io/cypress
enable-pr-comment: false
vcs-type: << pipeline.project.type >>
requires:
[orb-tools/lint, orb-tools/review, orb-tools/pack, shellcheck/check]
# Use a context to hold your publishing token.
context: circleci-orb-publishing
filters: *filters
# Triggers the next workflow in the Orb Development Kit.
- orb-tools/continue:
pipeline-number: << pipeline.number >>
vcs-type: << pipeline.project.type >>

orb-name => orb_name
enable-pr-comment => enable_pr_comment
etc.

This PR should be closed. If it is merged, then it will break the workflow again.

Workflow error is due to this. Note that it is looking for parameters with underscore:

Error calling workflow: 'lint-pack'
Error calling job: 'orb-tools/publish'
Missing required argument(s): orb_name, vcs_type

@renovate renovate bot force-pushed the renovate/orb-tools-12.x branch 2 times, most recently from 9af5944 to e63eb9e Compare July 24, 2024 19:57
@renovate renovate bot force-pushed the renovate/orb-tools-12.x branch from e63eb9e to d2f8415 Compare July 25, 2024 14:58
Copy link
Contributor Author

renovate bot commented Jul 30, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 12.x releases. But if you manually upgrade to 12.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/orb-tools-12.x branch July 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants