From ac428ec33f5a2556a3b0e94c51ccb157b8728b30 Mon Sep 17 00:00:00 2001 From: david Date: Mon, 13 May 2024 16:23:49 +0900 Subject: [PATCH] fix typo (scrollDrection -> scrollDirection) --- Sources/SushiBelt/SushiBeltTracker.swift | 10 +++++----- .../SushiBelt/SushiBeltTrackerScrollContext.swift | 4 ++-- Tests/SushiBeltTests/SushiBeltTrackerTests.swift | 14 +++++++------- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Sources/SushiBelt/SushiBeltTracker.swift b/Sources/SushiBelt/SushiBeltTracker.swift index b33c8f7..e9acc1e 100644 --- a/Sources/SushiBelt/SushiBeltTracker.swift +++ b/Sources/SushiBelt/SushiBeltTracker.swift @@ -80,7 +80,7 @@ extension SushiBeltTracker { guard let currentVisibleRatio = self.visibleRatioCalculator.visibleRatio( item: item, trackingRect: trackingRect, - scrollDirection: self.scrollDrection() + scrollDirection: self.scrollDirection() ) else { return } @@ -106,15 +106,15 @@ extension SushiBeltTracker { } } - internal func scrollDrection() -> SushiBeltTrackerScrollDirection? { + internal func scrollDirection() -> SushiBeltTrackerScrollDirection? { guard let scrollContext = self.scrollContext else { assertionFailure("scrollContext must not be null") return nil } - if let scrollDrection = scrollContext.scrollDrection() { + if let scrollDirection = scrollContext.scrollDirection() { // unsupported diagonal scroll tracking - return scrollDrection == .diagonal ? nil : scrollDrection + return scrollDirection == .diagonal ? nil : scrollDirection } else { return self.recentScrollDirection ?? self.defaultScrollDirection } @@ -126,7 +126,7 @@ extension SushiBeltTracker { extension SushiBeltTracker { private func cachingRecentScrollDirectionIfNeeded() { - guard let scrollDirection = self.scrollDrection() else { return } + guard let scrollDirection = self.scrollDirection() else { return } self.recentScrollDirection = scrollDirection } diff --git a/Sources/SushiBelt/SushiBeltTrackerScrollContext.swift b/Sources/SushiBelt/SushiBeltTrackerScrollContext.swift index 5860bb2..50a833a 100644 --- a/Sources/SushiBelt/SushiBeltTrackerScrollContext.swift +++ b/Sources/SushiBelt/SushiBeltTrackerScrollContext.swift @@ -22,7 +22,7 @@ public typealias PlatformScrollView = NSScrollView #endif public protocol SushiBeltTrackerScrollContext: AnyObject { - func scrollDrection() -> SushiBeltTrackerScrollDirection? + func scrollDirection() -> SushiBeltTrackerScrollDirection? } public final class SushiBeltTrackerUIScrollContext: SushiBeltTrackerScrollContext { @@ -32,7 +32,7 @@ public final class SushiBeltTrackerUIScrollContext: SushiBeltTrackerScrollContex self.scrollView = scrollView } - public func scrollDrection() -> SushiBeltTrackerScrollDirection? { + public func scrollDirection() -> SushiBeltTrackerScrollDirection? { guard let scrollView = self.scrollView else { return nil } diff --git a/Tests/SushiBeltTests/SushiBeltTrackerTests.swift b/Tests/SushiBeltTests/SushiBeltTrackerTests.swift index 73c2f48..6c2c15e 100644 --- a/Tests/SushiBeltTests/SushiBeltTrackerTests.swift +++ b/Tests/SushiBeltTests/SushiBeltTrackerTests.swift @@ -46,7 +46,7 @@ extension SushiBeltTrackerTests { self.panGestureRecognizer.velocityStub = .zero // when - let direction = tracker.scrollDrection() + let direction = tracker.scrollDirection() // then XCTAssertEqual(direction, .left) @@ -62,7 +62,7 @@ extension SushiBeltTrackerTests { self.panGestureRecognizer.velocityStub = .zero // when - let direction = tracker.scrollDrection() + let direction = tracker.scrollDirection() // then XCTAssertEqual(direction, .right) @@ -75,7 +75,7 @@ extension SushiBeltTrackerTests { self.panGestureRecognizer.velocityStub = .init(x: 0.0, y: -100.0) // when - let direction = tracker.scrollDrection() + let direction = tracker.scrollDirection() // then XCTAssertEqual(direction, .up) @@ -88,7 +88,7 @@ extension SushiBeltTrackerTests { self.panGestureRecognizer.velocityStub = .init(x: 0.0, y: 100.0) // when - let direction = tracker.scrollDrection() + let direction = tracker.scrollDirection() // then XCTAssertEqual(direction, .down) @@ -101,7 +101,7 @@ extension SushiBeltTrackerTests { self.panGestureRecognizer.velocityStub = .init(x: 100.0, y: 0.0) // when - let direction = tracker.scrollDrection() + let direction = tracker.scrollDirection() // then XCTAssertEqual(direction, .left) @@ -114,7 +114,7 @@ extension SushiBeltTrackerTests { self.panGestureRecognizer.velocityStub = .init(x: -100.0, y: 0.0) // when - let direction = tracker.scrollDrection() + let direction = tracker.scrollDirection() // then XCTAssertEqual(direction, .right) @@ -127,7 +127,7 @@ extension SushiBeltTrackerTests { self.panGestureRecognizer.velocityStub = .init(x: 100.0, y: 100.0) // when - let direction = tracker.scrollDrection() + let direction = tracker.scrollDirection() // then XCTAssertNil(direction)