Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the sanity of the config numbers (duration <= search_length) #56

Open
dala318 opened this issue Sep 27, 2024 · 0 comments · Fixed by #76 · May be fixed by #78
Open

Validate the sanity of the config numbers (duration <= search_length) #56

dala318 opened this issue Sep 27, 2024 · 0 comments · Fixed by #76 · May be fixed by #78
Assignees
Labels
enhancement New feature or request

Comments

@dala318
Copy link
Owner

dala318 commented Sep 27, 2024

The configuration numbers are not really aware of each others, that means that the settings could end up as if no valid range is possible.
For the moving planner this is no big deal as it will very likely result in that the planner is always on (there is only one possible duration and obviously it will be the cheapest (and most expensive) )
But when adding a static planner it becomes more relevant (or maybe not, does it only mak the window span over midnight, have to think a bit more about it...)

@dala318 dala318 added the enhancement New feature or request label Sep 27, 2024
@dala318 dala318 linked a pull request Dec 20, 2024 that will close this issue
@dala318 dala318 linked a pull request Dec 20, 2024 that will close this issue
@dala318 dala318 self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant