Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable background scrolling when the modal is open #229

Open
2 tasks done
raphaelbernhart opened this issue Sep 6, 2024 · 3 comments
Open
2 tasks done

feat: disable background scrolling when the modal is open #229

raphaelbernhart opened this issue Sep 6, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@raphaelbernhart
Copy link

Describe the feature

At least for me on mac the website is still scrollable even if the modal is opened. IMO it is common sense that the website scroll should be blocked when a modal is opened.

FYI - I'm open to create a MR for this but please add some feedback of your thoughts
Sidenote for me: keep iOS in mind when developing this feature.

Additional information

  • Would you be willing to help implement this feature?

Final checks

@dargmuesli
Copy link
Owner

Good idea, imho. Consider using headlessui/dialog, I'd say 💡

@dargmuesli dargmuesli changed the title Disable scrolling when the modal is open feat: disable scrolling when the modal is open Sep 13, 2024
@dargmuesli dargmuesli changed the title feat: disable scrolling when the modal is open feat: disable background scrolling when the modal is open Sep 13, 2024
@dargmuesli dargmuesli added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Sep 13, 2024
@raphaelbernhart
Copy link
Author

Good idea, imho. Consider using headlessui/dialog, I'd say 💡

Do you think headlessui could bloat the module unnecessarily? IMO installing a ui-library should be discussed as the module over all could then probably need a refactor?

Nevertheless I think the scroll-disable feature can also be added without installing a third-party (just FYI).
What do you think?

@raphaelbernhart
Copy link
Author

see #228 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants