From dfc4bbbe9dc95477797ed96e1b145cd478ba8dab Mon Sep 17 00:00:00 2001
From: Liam Appelbe <liama@google.com>
Date: Thu, 31 Aug 2023 10:35:29 +1200
Subject: [PATCH] Daco's comments

---
 .github/workflows/test-package.yml     | 1 +
 CHANGELOG.md                           | 2 +-
 lib/src/code_generator/objc_block.dart | 3 +++
 pubspec.yaml                           | 4 +++-
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test-package.yml b/.github/workflows/test-package.yml
index 3d40f977..134d7dfa 100644
--- a/.github/workflows/test-package.yml
+++ b/.github/workflows/test-package.yml
@@ -19,6 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        # TODO: Change to 3.2.0 stable once it's released.
         sdk: [3.2.0-114.0.dev]
     steps:
       - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
diff --git a/CHANGELOG.md b/CHANGELOG.md
index cd2aec7d..7036a8c4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 - Add support for ObjC Blocks that can be invoked from any thread, using
   NativeCallable.listener.
-- Bump min SDK version to 3.2.
+- Bump min SDK version to 3.2.0-114.0.dev.
 
 # 9.0.1
 
diff --git a/lib/src/code_generator/objc_block.dart b/lib/src/code_generator/objc_block.dart
index 12f60a0a..883acd73 100644
--- a/lib/src/code_generator/objc_block.dart
+++ b/lib/src/code_generator/objc_block.dart
@@ -143,6 +143,9 @@ class $name extends _ObjCBlockBase {
   /// capabilities and limitations. This block can be invoked from any thread,
   /// but only supports void functions, and is not run synchronously. See
   /// NativeCallable.listener for more details.
+  ///
+  /// Note that unlike the default behavior of NativeCallable.listener, listener
+  /// blocks do not keep the isolate alive.
   $name.listener(${w.className} lib, ${funcType.getDartType(w)} fn) :
       this._(lib.${builtInFunctions.newBlock.name}(
           (_dartFuncListenerTrampoline ??= $nativeCallableType.listener($closureTrampoline
diff --git a/pubspec.yaml b/pubspec.yaml
index 40eeb693..ae45a104 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -4,7 +4,9 @@
 
 name: ffigen
 version: 10.0.0-dev.0
-description: Generator for FFI bindings, using LibClang to parse C header files.
+description: >
+  Generator for FFI bindings, using LibClang to parse C, Objective-C, and Swift
+  files.
 repository: https://github.com/dart-lang/ffigen
 
 topics: