Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

web-angular: rework template and add basic component tests #396

Closed
chalin opened this issue May 4, 2017 · 4 comments
Closed

web-angular: rework template and add basic component tests #396

chalin opened this issue May 4, 2017 · 4 comments
Assignees

Comments

@chalin
Copy link
Contributor

chalin commented May 4, 2017

Part of #390.

@chalin chalin self-assigned this May 4, 2017
@chalin
Copy link
Contributor Author

chalin commented May 4, 2017

The current template allows the user to type her/his name and get a "Hello" message inside a modal dialog. Part of the issue is that we aren't able to write component tests for modal dialogs quite yet.

@kwalrath @filiph - these are the changes that I propose doing:

  1. Drop hello_dialog: instead, display the greeting in a "Greeting" tab (this can be tested). Looking like this

screen shot 2017-05-04 at 7 51 33 pm


screen shot 2017-05-04 at 7 43 09 pm

  1. Have a second tab named "Hall of Fame" that will be initially empty. This second tab will be populated by code which is added in the second part of the Get Started page; i.e. from this

screen shot 2017-05-04 at 7 43 55 pm

To this:

screen shot 2017-05-04 at 7 42 55 pm

Clicking a superhero name shows a "cheers!" dialog (which is the old hello_dialog repurposed). (We don't include the tests for this part of the code, so using a modal dialog is ok).

WDYT? Suggestions are welcome.

@chalin
Copy link
Contributor Author

chalin commented May 8, 2017

@kwalrath @filiph - FYI, here is a snapshot of the revised app:

screen shot 2017-05-08 at 5 12 22 pm

I'm looking at the tests now. Once that is done, I'll submit a new PR with the revised code.

chalin added a commit to chalin/stagehand that referenced this issue May 8, 2017
WIP: tests haven't been reworked (relative to previous PR).

Fixes dart-archive#396
@filiph
Copy link
Contributor

filiph commented May 8, 2017

Thanks! This looks amazing!

Where are we on the LOC front? From the screenshot it looks like a full-featured TODO app, which is awesome, but only if it's really just a few lines of code (in the ballpark of the current template).

If it's more than that, let's use your code as a medium article / sample / etc., because this is exactly what we need right now — but lets shave the code in the template to a bare minimum.

@chalin
Copy link
Contributor Author

chalin commented May 8, 2017

@filiph - the code (w/o the updated tests) is in #401. I'm stepping out, but will be available for discussion when I get back.

chalin added a commit to chalin/stagehand that referenced this issue May 9, 2017
kwalrath pushed a commit that referenced this issue May 9, 2017
…401)

Also:

* update to angular_components 0.5.1
* Ensure tool/grind.dart build ignores build directories

Fixes #396
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants