Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Pin pedantic lints to 1.8.0 #565

Open
kwalrath opened this issue Jul 23, 2018 · 5 comments
Open

Pin pedantic lints to 1.8.0 #565

kwalrath opened this issue Jul 23, 2018 · 5 comments
Labels

Comments

@kwalrath
Copy link
Contributor

kwalrath commented Jul 23, 2018

Related discussion: dart-lang/site-www#1016 (comment)

@kevmoo
Copy link
Contributor

kevmoo commented Aug 20, 2018

At a minimum, I think updating the templates to drop them is great.

Not 100% sure about enabling the lints for end users, though...

@kwalrath
Copy link
Contributor Author

kwalrath commented Jul 20, 2019

1.8.0 pedantic includes unnecessary_new & unnecessary_const, as does the stagehand options file. When we update stagehand (and its templates) to pedantic 1.8.0, we should remove duplicate declarations (such as unnecessary_new & unnecessary_const) from the the stagehand options file.

@kwalrath kwalrath changed the title Consider adding unnecessary_new and unnecessary_const to template & stagehand lints Update to pedantic 1.8.0 Jul 20, 2019
@kwalrath kwalrath changed the title Update to pedantic 1.8.0 Update/pin lints (pedantic? something else?) May 21, 2020
@kwalrath
Copy link
Contributor Author

We should avoid having a free-floating pedantic dependency, since that's likely to break code whenever devs do a pub upgrade.

If we continue to use pedantic, we should have something like this in each template's analysis_options.yaml file:

include: package:pedantic/analysis_options.1.9.0.yaml

Currently, the analysis options files have something like this (which I'm calling a free-floating pedantic dependency):

include: package:pedantic/analysis_options.yaml

@kwalrath
Copy link
Contributor Author

/cc @mit-mit

@mit-mit
Copy link
Contributor

mit-mit commented May 26, 2020

I'd recommend pinning to pedantic 1.8.0 for now. We're investigating using a different default set of lints, so no reason to push additional lints right now.

@kwalrath kwalrath changed the title Update/pin lints (pedantic? something else?) Pin pedantic lints to 1.8.0 May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants