Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_FakeTimer doesn't have a tick member #2299

Closed
chalin opened this issue Jul 16, 2018 · 1 comment
Closed

_FakeTimer doesn't have a tick member #2299

chalin opened this issue Jul 16, 2018 · 1 comment

Comments

@chalin
Copy link
Contributor

chalin commented Jul 16, 2018

As reported in dart-archive/http_retry#6, http_retry tests are now failing with this error:

> pub run test --platform vm
00:02 +0 -1: loading test/http_retry_test.dart [E]                                                                                                                                                     
  Failed to load "test/http_retry_test.dart":
  Unable to spawn isolate: file:///home/travis/.pub-cache/hosted/pub.dartlang.org/fake_async-0.1.2/lib/fake_async.dart:212:7: Error: The non-abstract class '_FakeTimer' is missing implementations for these members:
    'tick'.
  Try to either
   - provide an implementation,
   - inherit an implementation from a superclass or mixin,
   - mark the class as abstract, or
   - provide a 'noSuchMethod' implementation.
  
  class _FakeTimer implements Timer {
        ^^^^^^^^^^
  file:///home/travis/.pub-cache/hosted/pub.dartlang.org/fake_async-0.1.2/lib/fake_async.dart:247:61: Error: The static method has type '(dart.core::Comparable<dynamic>, dart.core::Comparable<dynamic>) → dart.core::int' that isn't of expected type '(dynamic, dynamic) → dart.core::int'.
  Change the type of the method or the context in which it is used.
  dynamic _minOf(Iterable i, [Comparator compare = Comparable.compare]) =>
                                                              ^
00:02 +0 -1: Some tests failed.  

See https://travis-ci.org/dart-lang/http_retry/builds/404507054

cc @kevmoo

@natebosch
Copy link
Member

There is a throwing implementation now. In dart-archive/fake_async#35 I'll look at making the implementation a little more realistic.

@mosuem mosuem transferred this issue from dart-archive/fake_async Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants