From eb49cbab81d54eb1c8552d5a591f906f822ada21 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Mon, 11 Sep 2023 08:43:09 -0700 Subject: [PATCH] [jnigen] Add `ignore_for_file: lines_longer_than_80_chars` to generated files (https://github.com/dart-lang/jnigen/issues/386) --- pkgs/jnigen/CHANGELOG.md | 1 + pkgs/jnigen/example/in_app_java/lib/android_utils.dart | 1 + pkgs/jnigen/example/kotlin_plugin/lib/kotlin_bindings.dart | 1 + pkgs/jnigen/example/notification_plugin/lib/notifications.dart | 1 + .../src/third_party/org/apache/pdfbox/pdmodel/PDDocument.dart | 1 + .../org/apache/pdfbox/pdmodel/PDDocumentInformation.dart | 1 + .../third_party/org/apache/pdfbox/text/PDFTextStripper.dart | 1 + pkgs/jnigen/lib/src/bindings/dart_generator.dart | 3 +++ .../dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart | 1 + .../dart_bindings/com/fasterxml/jackson/core/JsonParser.dart | 1 + .../dart_bindings/com/fasterxml/jackson/core/JsonToken.dart | 1 + .../dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart | 1 + .../dart_bindings/com/fasterxml/jackson/core/JsonParser.dart | 1 + .../dart_bindings/com/fasterxml/jackson/core/JsonToken.dart | 1 + pkgs/jnigen/test/kotlin_test/c_based/dart_bindings/kotlin.dart | 1 + .../test/kotlin_test/dart_only/dart_bindings/kotlin.dart | 1 + .../c_based/dart_bindings/simple_package.dart | 1 + .../dart_only/dart_bindings/simple_package.dart | 1 + 18 files changed, 20 insertions(+) diff --git a/pkgs/jnigen/CHANGELOG.md b/pkgs/jnigen/CHANGELOG.md index 76430af98..7e18e4020 100644 --- a/pkgs/jnigen/CHANGELOG.md +++ b/pkgs/jnigen/CHANGELOG.md @@ -1,4 +1,5 @@ ## 0.6.1-wip +* Add `ignore_for_file: lines_longer_than_80_chars` to the generated file preamble. * Added an explicit cast in generated `.implement` code to allow `dart analyze` to pass when `strict-casts` is set. ## 0.6.0 diff --git a/pkgs/jnigen/example/in_app_java/lib/android_utils.dart b/pkgs/jnigen/example/in_app_java/lib/android_utils.dart index 620adec8b..ec722865a 100644 --- a/pkgs/jnigen/example/in_app_java/lib/android_utils.dart +++ b/pkgs/jnigen/example/in_app_java/lib/android_utils.dart @@ -5,6 +5,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/example/kotlin_plugin/lib/kotlin_bindings.dart b/pkgs/jnigen/example/kotlin_plugin/lib/kotlin_bindings.dart index b7120d25a..ed2d034c0 100644 --- a/pkgs/jnigen/example/kotlin_plugin/lib/kotlin_bindings.dart +++ b/pkgs/jnigen/example/kotlin_plugin/lib/kotlin_bindings.dart @@ -5,6 +5,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/example/notification_plugin/lib/notifications.dart b/pkgs/jnigen/example/notification_plugin/lib/notifications.dart index 30664d566..ebb2f59ef 100644 --- a/pkgs/jnigen/example/notification_plugin/lib/notifications.dart +++ b/pkgs/jnigen/example/notification_plugin/lib/notifications.dart @@ -9,6 +9,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/pdmodel/PDDocument.dart b/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/pdmodel/PDDocument.dart index 59438087f..03a9da2a3 100644 --- a/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/pdmodel/PDDocument.dart +++ b/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/pdmodel/PDDocument.dart @@ -23,6 +23,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/pdmodel/PDDocumentInformation.dart b/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/pdmodel/PDDocumentInformation.dart index 268557214..d928d2137 100644 --- a/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/pdmodel/PDDocumentInformation.dart +++ b/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/pdmodel/PDDocumentInformation.dart @@ -23,6 +23,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/text/PDFTextStripper.dart b/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/text/PDFTextStripper.dart index 556d83a80..b42cd9a60 100644 --- a/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/text/PDFTextStripper.dart +++ b/pkgs/jnigen/example/pdfbox_plugin/lib/src/third_party/org/apache/pdfbox/text/PDFTextStripper.dart @@ -23,6 +23,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/lib/src/bindings/dart_generator.dart b/pkgs/jnigen/lib/src/bindings/dart_generator.dart index ead431f2e..d8fb60d03 100644 --- a/pkgs/jnigen/lib/src/bindings/dart_generator.dart +++ b/pkgs/jnigen/lib/src/bindings/dart_generator.dart @@ -144,12 +144,15 @@ import "package:jni/internal_helpers_for_jnigen.dart"; import "package:jni/jni.dart" as jni; '''; + + // Sort alphabetically. static const defaultLintSuppressions = ''' // ignore_for_file: annotate_overrides // ignore_for_file: camel_case_extensions // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart b/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart index 4ebdfd9cd..e1f19fe50 100644 --- a/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart +++ b/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart @@ -22,6 +22,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonParser.dart b/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonParser.dart index 3ea73b13c..1dac51cc5 100644 --- a/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonParser.dart +++ b/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonParser.dart @@ -22,6 +22,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonToken.dart b/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonToken.dart index da95cb6e5..fdbd542ad 100644 --- a/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonToken.dart +++ b/pkgs/jnigen/test/jackson_core_test/third_party/c_based/dart_bindings/com/fasterxml/jackson/core/JsonToken.dart @@ -22,6 +22,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart b/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart index 3677ba171..f9f363166 100644 --- a/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart +++ b/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonFactory.dart @@ -22,6 +22,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonParser.dart b/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonParser.dart index 7d0dceb12..ae607a98f 100644 --- a/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonParser.dart +++ b/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonParser.dart @@ -22,6 +22,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonToken.dart b/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonToken.dart index 6b60adb27..da0a49e5c 100644 --- a/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonToken.dart +++ b/pkgs/jnigen/test/jackson_core_test/third_party/dart_only/dart_bindings/com/fasterxml/jackson/core/JsonToken.dart @@ -22,6 +22,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/kotlin_test/c_based/dart_bindings/kotlin.dart b/pkgs/jnigen/test/kotlin_test/c_based/dart_bindings/kotlin.dart index 1792649fc..5b80bb881 100644 --- a/pkgs/jnigen/test/kotlin_test/c_based/dart_bindings/kotlin.dart +++ b/pkgs/jnigen/test/kotlin_test/c_based/dart_bindings/kotlin.dart @@ -9,6 +9,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/kotlin_test/dart_only/dart_bindings/kotlin.dart b/pkgs/jnigen/test/kotlin_test/dart_only/dart_bindings/kotlin.dart index 357e6e51c..c352dfb02 100644 --- a/pkgs/jnigen/test/kotlin_test/dart_only/dart_bindings/kotlin.dart +++ b/pkgs/jnigen/test/kotlin_test/dart_only/dart_bindings/kotlin.dart @@ -9,6 +9,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/simple_package_test/c_based/dart_bindings/simple_package.dart b/pkgs/jnigen/test/simple_package_test/c_based/dart_bindings/simple_package.dart index 345a1c2b5..2879e351c 100644 --- a/pkgs/jnigen/test/simple_package_test/c_based/dart_bindings/simple_package.dart +++ b/pkgs/jnigen/test/simple_package_test/c_based/dart_bindings/simple_package.dart @@ -9,6 +9,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields diff --git a/pkgs/jnigen/test/simple_package_test/dart_only/dart_bindings/simple_package.dart b/pkgs/jnigen/test/simple_package_test/dart_only/dart_bindings/simple_package.dart index e534bf517..b549cc89a 100644 --- a/pkgs/jnigen/test/simple_package_test/dart_only/dart_bindings/simple_package.dart +++ b/pkgs/jnigen/test/simple_package_test/dart_only/dart_bindings/simple_package.dart @@ -9,6 +9,7 @@ // ignore_for_file: camel_case_types // ignore_for_file: constant_identifier_names // ignore_for_file: file_names +// ignore_for_file: lines_longer_than_80_chars // ignore_for_file: no_leading_underscores_for_local_identifiers // ignore_for_file: non_constant_identifier_names // ignore_for_file: overridden_fields