diff --git a/app/lib/frontend/templates/views/pkg/index.dart b/app/lib/frontend/templates/views/pkg/index.dart index c3ee64cb57..6c3f86f05d 100644 --- a/app/lib/frontend/templates/views/pkg/index.dart +++ b/app/lib/frontend/templates/views/pkg/index.dart @@ -272,7 +272,7 @@ d.Node _filterSection({ image: d.Image( src: staticUrls .getAssetUrl('/static/img/search-form-foldable-icon.svg'), - alt: 'fold toggle icon (up/down arrow)', + alt: 'fold toggle (up/down arrow)', width: 13, height: 6, ), diff --git a/app/lib/frontend/templates/views/pkg/liked_package_list.dart b/app/lib/frontend/templates/views/pkg/liked_package_list.dart index b9f0aeba89..83c6cc8668 100644 --- a/app/lib/frontend/templates/views/pkg/liked_package_list.dart +++ b/app/lib/frontend/templates/views/pkg/liked_package_list.dart @@ -43,7 +43,7 @@ d.Node likedPackageListNode(List likes) { }, icon: d.Image( src: thumbUpFilledUrl, - alt: 'thumb up icon', + alt: 'thumb up', width: 24, height: 24, ), diff --git a/app/lib/frontend/templates/views/pkg/package_list.dart b/app/lib/frontend/templates/views/pkg/package_list.dart index ea7647fd09..923d5ac8e5 100644 --- a/app/lib/frontend/templates/views/pkg/package_list.dart +++ b/app/lib/frontend/templates/views/pkg/package_list.dart @@ -228,11 +228,11 @@ d.Node _item({ image: d.Image( src: staticUrls.getAssetUrl('/static/img/schedule-icon.svg'), - alt: 'icon indicating recent time', + alt: 'recently created package', width: 10, height: 10, ), - title: 'new package', + title: 'recently created package', ), d.text(' Added '), d.b(text: formatXAgo(age)), diff --git a/app/lib/frontend/templates/views/pkg/score_tab.dart b/app/lib/frontend/templates/views/pkg/score_tab.dart index ecb89626e0..7e77e843c6 100644 --- a/app/lib/frontend/templates/views/pkg/score_tab.dart +++ b/app/lib/frontend/templates/views/pkg/score_tab.dart @@ -114,7 +114,7 @@ d.Node _section(ReportSection section) { classes: ['pkg-report-icon'], image: d.Image( src: _statusIconUrls[section.status]!, - alt: 'icon indicating section status', + alt: _statusIconAlts[section.status]!, width: 18, height: 18, ), @@ -176,6 +176,12 @@ final _statusIconUrls = { staticUrls.getAssetUrl('/static/img/report-missing-icon-red.svg'), }; +final _statusIconAlts = { + ReportStatus.passed: 'OK', + ReportStatus.partial: 'partial', + ReportStatus.failed: 'failed', +}; + String _updatedSummary(String summary) { return summary.split('\n').map((line) { if (!line.startsWith('### ')) return line; diff --git a/app/lib/frontend/templates/views/pkg/title_content.dart b/app/lib/frontend/templates/views/pkg/title_content.dart index dd7632ff29..4f88a209ae 100644 --- a/app/lib/frontend/templates/views/pkg/title_content.dart +++ b/app/lib/frontend/templates/views/pkg/title_content.dart @@ -22,7 +22,7 @@ d.Node titleContentNode({ }, image: d.Image( src: staticUrls.getAssetUrl('/static/img/content-copy-icon.svg'), - alt: 'icon indicating copy to clipboard operation', + alt: 'copy "$package: ^$version" to clipboard', width: 18, height: 18, ), diff --git a/app/lib/frontend/templates/views/publisher/header_metadata.dart b/app/lib/frontend/templates/views/publisher/header_metadata.dart index 96086529b7..5fa68ef3be 100644 --- a/app/lib/frontend/templates/views/publisher/header_metadata.dart +++ b/app/lib/frontend/templates/views/publisher/header_metadata.dart @@ -22,14 +22,14 @@ d.Node publisherHeaderMetadataNode(Publisher publisher) { href: websiteUri.toString(), rel: websiteRel, label: websiteDisplayable!, - iconAlt: 'icon indicating a website link', + iconAlt: 'link to website', ), if (publisher.hasContactEmail) _ref( href: 'mailto:${publisher.contactEmail}', label: publisher.contactEmail!, iconPath: '/static/img/email-icon.svg', - iconAlt: 'icon indicating an email', + iconAlt: 'contact email', ), ]), d.p( diff --git a/app/lib/frontend/templates/views/shared/detail/header.dart b/app/lib/frontend/templates/views/shared/detail/header.dart index 3f190c43af..1cd323866a 100644 --- a/app/lib/frontend/templates/views/shared/detail/header.dart +++ b/app/lib/frontend/templates/views/shared/detail/header.dart @@ -96,14 +96,14 @@ d.Node detailHeaderNode({ onIcon: d.Image( src: staticUrls .getAssetUrl('/static/img/like-active.svg'), - alt: 'icon indicating liked status (active)', + alt: 'liked status: active', width: 18, height: 18, ), offIcon: d.Image( src: staticUrls.getAssetUrl( '/static/img/like-inactive.svg'), - alt: 'icon indicating liked status (inactive)', + alt: 'liked status: inactive', width: 18, height: 18, ), diff --git a/app/lib/frontend/templates/views/shared/images.dart b/app/lib/frontend/templates/views/shared/images.dart index 1885e3a56a..319c9ce2b8 100644 --- a/app/lib/frontend/templates/views/shared/images.dart +++ b/app/lib/frontend/templates/views/shared/images.dart @@ -9,7 +9,7 @@ import '../../../static_files.dart'; d.Image verifiedPublisherIconImage() { return d.Image( src: staticUrls.getAssetUrl('/static/img/material-icon-verified.svg'), - alt: 'verified publisher icon', + alt: 'verified publisher', width: 14, height: 14, ); @@ -17,9 +17,8 @@ d.Image verifiedPublisherIconImage() { /// Returns the image object for license icon. d.Image licenseIconImage() { - return d.Image( + return d.Image.decorative( src: staticUrls.getAssetUrl('/static/img/material-icon-balance.svg'), - alt: 'Icon for licenses.', width: 14, height: 14, ); diff --git a/app/lib/frontend/templates/views/shared/layout.dart b/app/lib/frontend/templates/views/shared/layout.dart index 8e8dad6191..38e19116ed 100644 --- a/app/lib/frontend/templates/views/shared/layout.dart +++ b/app/lib/frontend/templates/views/shared/layout.dart @@ -275,7 +275,7 @@ d.Node _siteFooterNode() { ['sep'], d.Image( src: staticUrls.getAssetUrl('/static/img/rss-feed-icon.svg'), - alt: 'RSS icon', + alt: 'RSS', width: 20, height: 20, ), @@ -286,7 +286,7 @@ d.Node _siteFooterNode() { ['github_issue'], d.Image( src: staticUrls.getAssetUrl('/static/img/bug-report-white-96px.png'), - alt: 'bug report icon', + alt: 'bug report', width: 20, height: 20, ), diff --git a/app/test/frontend/golden/authorized_page.html b/app/test/frontend/golden/authorized_page.html index 0c61e84a4d..7586704f73 100644 --- a/app/test/frontend/golden/authorized_page.html +++ b/app/test/frontend/golden/authorized_page.html @@ -122,10 +122,10 @@

Pub Authorized Successfully

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/consent_page.html b/app/test/frontend/golden/consent_page.html index 44cfe65d4c..ff06e5d73b 100644 --- a/app/test/frontend/golden/consent_page.html +++ b/app/test/frontend/golden/consent_page.html @@ -125,10 +125,10 @@

Invite for something

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/create_publisher_page.html b/app/test/frontend/golden/create_publisher_page.html index 07887ea7db..53afa553ed 100644 --- a/app/test/frontend/golden/create_publisher_page.html +++ b/app/test/frontend/golden/create_publisher_page.html @@ -189,10 +189,10 @@

Create a verified publisher

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/error_page.html b/app/test/frontend/golden/error_page.html index 074358d0f6..e460960718 100644 --- a/app/test/frontend/golden/error_page.html +++ b/app/test/frontend/golden/error_page.html @@ -120,10 +120,10 @@

error_title

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/help_page.html b/app/test/frontend/golden/help_page.html index 6c1163e705..58db4c5065 100644 --- a/app/test/frontend/golden/help_page.html +++ b/app/test/frontend/golden/help_page.html @@ -157,10 +157,10 @@

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/landing_page.html b/app/test/frontend/golden/landing_page.html index 5d91c1c4a3..57f8fe0a9b 100644 --- a/app/test/frontend/golden/landing_page.html +++ b/app/test/frontend/golden/landing_page.html @@ -159,7 +159,7 @@

neon

- verified publisher icon + verified publisher example.com
@@ -209,10 +209,10 @@

Package of the Week

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/my_activity_log_page.html b/app/test/frontend/golden/my_activity_log_page.html index 27ef4b9cd0..8419b60a6f 100644 --- a/app/test/frontend/golden/my_activity_log_page.html +++ b/app/test/frontend/golden/my_activity_log_page.html @@ -341,10 +341,10 @@

admin

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/my_liked_packages.html b/app/test/frontend/golden/my_liked_packages.html index 894cb22c63..f12da327d3 100644 --- a/app/test/frontend/golden/my_liked_packages.html +++ b/app/test/frontend/golden/my_liked_packages.html @@ -184,7 +184,7 @@

@@ -202,7 +202,7 @@

@@ -229,10 +229,10 @@

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html index b5fc1a4328..aa429e1eef 100644 --- a/app/test/frontend/golden/my_packages.html +++ b/app/test/frontend/golden/my_packages.html @@ -185,7 +185,7 @@

oxygen

- icon indicating recent time + recently created package Added %%x-ago%%
@@ -232,7 +232,7 @@

) - Icon for licenses. + BSD-3-Clause

@@ -261,7 +261,7 @@

neon

- icon indicating recent time + recently created package Added %%x-ago%%
@@ -304,11 +304,11 @@

) - verified publisher icon + verified publisher example.com - Icon for licenses. + BSD-3-Clause

@@ -361,10 +361,10 @@

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/my_publishers.html b/app/test/frontend/golden/my_publishers.html index 9a4d8bad8d..e546f6adc7 100644 --- a/app/test/frontend/golden/my_publishers.html +++ b/app/test/frontend/golden/my_publishers.html @@ -207,10 +207,10 @@

Want to create a new publisher?

Privacy Help - RSS icon + RSS - bug report icon + bug report diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html index bf8e497008..7dca536bb1 100644 --- a/app/test/frontend/golden/pkg_activity_log_page.html +++ b/app/test/frontend/golden/pkg_activity_log_page.html @@ -142,7 +142,7 @@

oxygen 1.2.0 - icon indicating copy to clipboard operation + copy "oxygen: ^1.2.0" to clipboard
oxygen: ^1.2.0 copied to clipboard @@ -183,8 +183,8 @@