Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Publish" workflow analyzes .pubignored files #4035

Closed
osa1 opened this issue Oct 27, 2023 · 2 comments
Closed

"Publish" workflow analyzes .pubignored files #4035

osa1 opened this issue Oct 27, 2023 · 2 comments

Comments

@osa1
Copy link
Member

osa1 commented Oct 27, 2023

In https://github.com/google/protobuf.dart we use dart-lang/ecosystem/.github/workflows/publish.yaml workflow to perform publishing checks.

Currently this workflow fails in dart analyze step because dart analyze analyzes tests, and tests need a build step to run (make protos).

This behavior makes sense when working on the package, however when doing publication validation, we need to either

  1. Run the build step make protos before dart analyze, which currently the workflow does not support

    • Note that the git repo has two packages, and we only want to do this in one of them
  2. Or, make it .pubignore-aware

I feel like (2) makes sense in general as analyzing with non-published files can actually hide problems, for example if I accidentally add a file to .pubignore that's actually needed by the package.

(google/protobuf.dart#894 adds the tests to .pubignore)

@mosuem mosuem transferred this issue from dart-lang/ecosystem Oct 27, 2023
@mosuem
Copy link
Member

mosuem commented Oct 27, 2023

Transferred as this is mainly a feature request to dart pub publish

@sigurdm
Copy link
Contributor

sigurdm commented Oct 30, 2023

Yeah - we need a good way to remove those files from analysis.

Duplicate of: #3696

@sigurdm sigurdm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants