You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently this workflow fails in dart analyze step because dart analyze analyzes tests, and tests need a build step to run (make protos).
This behavior makes sense when working on the package, however when doing publication validation, we need to either
Run the build step make protos before dart analyze, which currently the workflow does not support
Note that the git repo has two packages, and we only want to do this in one of them
Or, make it .pubignore-aware
I feel like (2) makes sense in general as analyzing with non-published files can actually hide problems, for example if I accidentally add a file to .pubignore that's actually needed by the package.
In https://github.com/google/protobuf.dart we use
dart-lang/ecosystem/.github/workflows/publish.yaml
workflow to perform publishing checks.Currently this workflow fails in
dart analyze
step becausedart analyze
analyzes tests, and tests need a build step to run (make protos
).This behavior makes sense when working on the package, however when doing publication validation, we need to either
Run the build step
make protos
beforedart analyze
, which currently the workflow does not supportOr, make it
.pubignore
-awareI feel like (2) makes sense in general as analyzing with non-published files can actually hide problems, for example if I accidentally add a file to
.pubignore
that's actually needed by the package.(google/protobuf.dart#894 adds the tests to
.pubignore
)The text was updated successfully, but these errors were encountered: