Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Update side-nav.yml #6202

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

iveloff-developer
Copy link
Contributor

src/content/language/loops.md and src/content/language/branches.md both refer to src/content/language/error-handling.md as a part of Control Flow in Dart that seems logical. To make docs little more consistent, it's a good idea to move 'Error Handling' topic under 'Control Flow' header inside side navigation panel.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

src/content/language/loops.md and src/content/language/branches.md both refer to src/content/language/error-handling.md as a part of Control Flow in Dart that seems logical. So it's a good idea to move Error Handling topic under Control Flow header inside side navigation panel.
@MaryaBelanger
Copy link
Contributor

/gcbrun

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Nov 12, 2024

Visit the preview URL for this PR (updated for commit 6fc7095):

https://dart-dev--pr6202-main-8zoaysz0.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but I'll let @MaryaBelanger decide.

Thanks so much for thinking about this and the pull request!

@parlough
Copy link
Member

/gcbrun

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Thanks @iveloff-developer

@MaryaBelanger MaryaBelanger merged commit 0e885fa into dart-lang:main Nov 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants