-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a header option to combining_builder #370
Comments
I'd also prefer if there were a better way to silence these lints in the analyzer. Filed dart-lang/sdk#34069 to see if we can avoid having to hack around lints in generated code like this. |
I also prefer configuring the analyzer, but because that dodn't work, using the header was a convemient workaround. |
Alternatively, built_value or any other code generator could still support lints via the build_config. Instead of passing those into source_gen's builder like built_value did here built_value could pass it to it's generator |
This is blocking google/json_serializable.dart#557 |
This should not be blocking. I think you can drop an |
Really annoying? |
The
header
option was removed fromPartBuilder
because individual builders no longer control the entire end file at.g.dart
- it's now a concatenation of all.something.g.part
files which might be produced by other builders as well. The ordering isn't controllable. Since we don't know which file will be first a "header" might not end up at the top of the resulting file.We could add a header option to
source_gen|combining_builder
. I was originally opposed to doing this because:source_gen
and the combining builder becomes an implementation detail that the end user depends on.I've now heard a new use case which is adding
//ignore_for_file:
comments for opt in lints that the builder authors aren't aware of.I still think (2) is a bummer but this is a pretty good reason to want a header. Technically these comment don't need to be at the top of the file and we could put them back as "section headers" in the individual parts which might end up anywhere in the result file, but I'm not sure that's much better than having to learn about a new builder name to configure the header on.
cc @kevmoo who was right about this from the beginning.
The text was updated successfully, but these errors were encountered: