Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should we do about InvalidGenerationSourceError.todo? #480

Open
kevmoo opened this issue Sep 10, 2020 · 2 comments
Open

What should we do about InvalidGenerationSourceError.todo? #480

kevmoo opened this issue Sep 10, 2020 · 2 comments

Comments

@kevmoo
Copy link
Member

kevmoo commented Sep 10, 2020

https://pub.dev/documentation/source_gen/latest/source_gen/InvalidGenerationSourceError/todo.html

Back in the day, I used to actually output errors to the target file with // TODO: message. We don't do that anymore.

This is heavily related to #454, obviously.

In the short term, I could simply add todo content (it if exists) to the toString of InvalidGenerationSourceError.

I can also mark todo as deprecated.

Thoughts? @natebosch @davidmorgan @matanlurey @jakemac53
kevmoo added a commit to google/json_serializable.dart that referenced this issue Sep 10, 2020
@kevmoo
Improve error message when @JsonSerializable is used with generics
02653f9 
Follow-up on
#714
ae72259

Also drop use of InvalidGenerationSourceError.todo

See dart-lang/source_gen#480
@kevmoo kevmoo mentioned this issue Sep 10, 2020
Merged
kevmoo added a commit to google/json_serializable.dart that referenced this issue Sep 10, 2020
@kevmoo
Improve error message when @JsonSerializable is used with generics (#715
9f6c8b9 
)

Follow-up on #714

Also drop use of `InvalidGenerationSourceError.todo`

See dart-lang/source_gen#480
@natebosch
Copy link
Member

We should be able to deprecate the entire class.

@kevmoo
Copy link
Member Author

kevmoo commented Sep 10, 2020

Sure. What's the replacement?

Do we need to wait on dart-lang/build#981 ?

InvalidGenerationSourceError has the magic that turns an element into a pretty code snippet. We'd want to keep that in some form, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @natebosch