Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot revive ProcessStartMode.normal #577

Closed
srawlins opened this issue Dec 9, 2021 · 0 comments · Fixed by #578
Closed

Cannot revive ProcessStartMode.normal #577

srawlins opened this issue Dec 9, 2021 · 0 comments · Fixed by #578
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@srawlins
Copy link
Member

srawlins commented Dec 9, 2021 •
edited
Loading

In mockito, we might try to revive a constant, ProcessStartMode.normal (docs), but source_gen always gives back ProcessStartMode._internal() (the constructor used by normal).

I can reproduce this in constants_test, where the LibraryElement for dart.io has zero types, classes, etc. and so never tries ProcessMode.normal as a Revive. Very strange... :(

Similar to #547, but not the same bug, I believe.
@srawlins srawlins added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Dec 9, 2021
@srawlins srawlins mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reviving: Prefer static constant fields on constant object's class dart-lang/source_gen
1 participant
@srawlins