Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old _versionChecks #531

Closed
liamappelbe opened this issue Jul 30, 2024 · 1 comment · Fixed by dart-archive/coverage#502
Closed

Remove old _versionChecks #531

liamappelbe opened this issue Jul 30, 2024 · 1 comment · Fixed by dart-archive/coverage#502
Assignees
@liamappelbe
Labels
package:coverage type-cleanup

Comments

@liamappelbe
Copy link
Contributor

dart-archive/coverage#494 bumped the minimum SDK version to 3.4.0. That means that some of the _versionChecks in _getAllCoverage are unnecessary. We should be able to clean up some old code paths.
@liamappelbe liamappelbe self-assigned this Jul 30, 2024
@liamappelbe
Copy link
Contributor Author

in Dart 3.4.0, the VM service version was 4.13. That means we can just barely delete all the version checks (the last one is literally _versionCheck(version, 4, 13) 😉).

@liamappelbe liamappelbe mentioned this issue Aug 6, 2024
Merged
@mosuem mosuem transferred this issue from dart-archive/coverage Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
package:coverage type-cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove old version checks dart-archive/coverage
2 participants
@liamappelbe @mosuem