-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate test failures on Windows after Dart 2.17.0 release #1613
Comments
This is only occurring on Windows. It is possible that web debugging on Windows is currently broken. |
I keep encountering the following flakes:
I was running some tests on windows and saw those failures as well. The devtools_tests failures seem to be due to a race - we are waiting for couple of seconds after pressing Alt-D and before checking for existence of the devtools window, but it seems this is not always enough time. We might need a more reliable way of detecting when devtools window have started - one way could be by listening to dwds.events and waiting for webdev/dwds/test/devtools_test.dart Line 39 in c1d2237
I have not seen those while running tests on my windows laptop, but have encountered the flake in CI.
I only have seen this in CI, seems like it might be a race condition. This test used to be disabled on windows for being flaky, and enabled after a few race condition fixes. Looks like the flakiness has returned.
|
There are a couple tests that have been consistently flaky since updating the min constraint to Dart 2.17.0
#1612 is a draft PR to try to fix the flakes, skipping them for Windows. It looks like the debug connection is being shut down on Windows only.
The text was updated successfully, but these errors were encountered: