From f0af92fc0e56f65f084f39bce5b96c617e064aa1 Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Mon, 13 Jun 2022 11:51:48 -0700 Subject: [PATCH 1/3] Migrate dwds/tool directory to null safety --- dwds/tool/copy_builder.dart | 2 -- 1 file changed, 2 deletions(-) diff --git a/dwds/tool/copy_builder.dart b/dwds/tool/copy_builder.dart index 99e10bc7c..93f9b9707 100644 --- a/dwds/tool/copy_builder.dart +++ b/dwds/tool/copy_builder.dart @@ -2,8 +2,6 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// @dart = 2.9 - import 'package:build/build.dart'; /// Factory for the build script. From ec4acf4572ee89329ef02c82afd15ca3c1a0752a Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Mon, 13 Jun 2022 11:59:58 -0700 Subject: [PATCH 2/3] Ignored false positive analyzer warning --- dwds/lib/src/utilities/sdk_configuration.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/dwds/lib/src/utilities/sdk_configuration.dart b/dwds/lib/src/utilities/sdk_configuration.dart index eb650187e..03f5f46b2 100644 --- a/dwds/lib/src/utilities/sdk_configuration.dart +++ b/dwds/lib/src/utilities/sdk_configuration.dart @@ -120,6 +120,7 @@ class SdkConfiguration { class DefaultSdkConfigurationProvider extends SdkConfigurationProvider { DefaultSdkConfigurationProvider(); + // ignore: prefer_final_fields late SdkConfiguration _configuration = _create(); /// Create and validate configuration matching the default SDK layout. From e3240e5098e475bc2578c1b2826b8eb387945c85 Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Mon, 13 Jun 2022 14:51:08 -0700 Subject: [PATCH 3/3] Addressed PR comments --- dwds/lib/src/utilities/sdk_configuration.dart | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dwds/lib/src/utilities/sdk_configuration.dart b/dwds/lib/src/utilities/sdk_configuration.dart index 03f5f46b2..0439e01e6 100644 --- a/dwds/lib/src/utilities/sdk_configuration.dart +++ b/dwds/lib/src/utilities/sdk_configuration.dart @@ -120,8 +120,7 @@ class SdkConfiguration { class DefaultSdkConfigurationProvider extends SdkConfigurationProvider { DefaultSdkConfigurationProvider(); - // ignore: prefer_final_fields - late SdkConfiguration _configuration = _create(); + late final SdkConfiguration _configuration = _create(); /// Create and validate configuration matching the default SDK layout. @override