-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Poetry to manage project dependencies #57
Comments
I'll look at this before doing #27 mkdocs as need to make sure all the actions, packages and deploy still work. |
There is a issue in the way the current project handles version numbers and how poetry handles versioning and want to know @davidlatwe that a solution discussed here is ok python-poetry/poetry#1036 (comment) currently versions are managed in the The proposed solution is to:
another discussions around this issue: |
Thanks @madeinoz67 and the sum up. ❤️ Yeah.. I remember I bump into this issue when I was trying to adopt poetry a while back. Couldn't made up my mind which way to go at the time being. I read both issues and that PyPA guy's solution seems to be the most solid one, let's do it. :) |
@davidlatwe this is ready for your review just as an overview of changes:
Regarding the package versioning.... To keep things simple I decided to go with a simpler solution posted in the thread I mentioned above that just checks versions are in sync so you need to update versions in the pyproject.toml and the _version.py file. Ive added tests around this so will fail before publishing if they're not the same, also part of the CI The publishing action is the only thing I haven't been able to test, but should work as it's similar to what Ive done elsewhere. |
Add poetry to the project to manage its dependencies
initial discussion found here: #27
The text was updated successfully, but these errors were encountered: