Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing quote in fixtures.py #8324

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix missing quote in fixtures.py #8324

merged 1 commit into from
Aug 7, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Aug 4, 2023

resolves # none
docs dbt-labs/docs.getdbt.com/#

Problem

Syntax error on fixture that wasn't caught as an error because parse doesn't catch it, only run.

Solution

Add missing quote.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Aug 4, 2023
@emmyoop emmyoop requested a review from a team as a code owner August 4, 2023 19:44
@emmyoop emmyoop requested a review from martynydbt August 4, 2023 19:44
@cla-bot cla-bot bot added the cla:yes label Aug 4, 2023
@emmyoop emmyoop requested review from QMalcolm and removed request for martynydbt August 4, 2023 19:45
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #8324 (5815320) into main (f637092) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8324      +/-   ##
==========================================
- Coverage   86.28%   86.22%   -0.06%     
==========================================
  Files         174      174              
  Lines       25518    25518              
==========================================
- Hits        22017    22004      -13     
- Misses       3501     3514      +13     

see 3 files with indirect coverage changes

@emmyoop emmyoop self-assigned this Aug 4, 2023
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

@emmyoop emmyoop merged commit 44d1e73 into main Aug 7, 2023
57 of 58 checks passed
@emmyoop emmyoop deleted the er/syntax-error branch August 7, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants