Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS Glue adapter to trusted list #4091

Closed
5 tasks done
mehdimld opened this issue Sep 19, 2023 · 2 comments · Fixed by #4437
Closed
5 tasks done

Add AWS Glue adapter to trusted list #4091

mehdimld opened this issue Sep 19, 2023 · 2 comments · Fixed by #4437
Assignees
@dataders
Labels
adapter maintainers When maintainers want to add an adapter as trusted or verified

Comments

@mehdimld
Copy link
Contributor

Link to adapter repo

https://github.com/aws-samples/dbt-glue

Contact Details

mehdmldj@amazon.com

Which of these best describes you?

I work for the vendor on top of which the dbt adapter functions

Please agree to the each of the following

  • I am a maintainer of the adapter being submited for Trusted status
  • I have read both the Trusted adapters and Building a Trusted Adapter pages.
  • I believe that the adapter currently meets the expectations given above
  • I will ensure this adapter stays in compliance with the guidelines
  • I understand that dbt Labs reserves the right to remove an adapter from the trusted adapter list at any time, should any of the below guidelines not be met

What icon should be used?

image
@mehdimld mehdimld added the adapter maintainers When maintainers want to add an adapter as trusted or verified label Sep 19, 2023
@dataders
Copy link
Contributor

dataders commented Oct 2, 2023 •
edited
Loading

discussed offline with @mehdimld and @menuetb -- we're going to hold off on adding to Trusted, until the aws-samples/dbt-glue repo has CI run against the dbt-adapter-test suite that shows the adapter is in working order. I opened aws-samples/dbt-glue#240 to document the work

for now I'm going to close this issue so that it doesn't interfere with the product docs team's triage process/states

@dataders dataders mentioned this issue Oct 2, 2023
Closed
@moomindani
Copy link

Thanks for your advise, we have added CI and resolved aws-samples/dbt-glue#240.
Can we move forward?

@dataders dataders mentioned this issue Nov 10, 2023
Merged
2 tasks
mirnawong1 added a commit that referenced this issue Nov 17, 2023
@mirnawong1
Glue is trusted (#4437)
e1fca0f 
## What are you changing in this pull request and why?
<!---
Describe your changes and why you're making them. If linked to an open
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

resolves: #4091 

## Checklist

- [ ] dbt-glue repo has PR CI checks enabled by "ok to test" label
- [ ] all tests available in dbt Labs provided suite are present, with
those don't pass commented out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dataders dataders

Labels
adapter maintainers When maintainers want to add an adapter as trusted or verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Glue is trusted dbt-labs/docs.getdbt.com
3 participants
@moomindani @dataders @mehdimld