Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loaded_at_field not required for source freshness checks as-of 1.7 #4615

Closed
1 task done
Tracked by #1044
dbeatty10 opened this issue Dec 8, 2023 · 1 comment · Fixed by #4770
Closed
1 task done
Tracked by #1044

loaded_at_field not required for source freshness checks as-of 1.7 #4615

dbeatty10 opened this issue Dec 8, 2023 · 1 comment · Fixed by #4770
Assignees
@matthewshaver
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix. source freshness

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Dec 8, 2023 •
edited
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/resource-properties/freshness

What part(s) of the page would you like to see updated?

Two things:

  1. Update the page based off the information listed in the v1.7 migration guide.
  2. Explain (on one or more pages) which adapters require loaded_at_field in order to calculate freshness and which can be calculated from metadata.

Platforms that support freshness from metadata

Currently, only Snowflake can calculate from metadata, but consult the following list of issues to track if other adapters add support:

Achieving a mix of null and non-null for loaded_at_field

dbt-labs/dbt-core#9320 (comment)

Additional information

Additional information can be found in the following places:

Instigating issue

This came up during discussion of this regression: dbt-labs/dbt-bigquery#1044

We have information related to loaded_at_field vs. database metadata in the upgrade guide, but we don't yet have it within the docs for freshness.
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Dec 8, 2023
@dbeatty10 dbeatty10 mentioned this issue Dec 8, 2023
Closed
2 tasks
@graciegoheen graciegoheen added priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix. labels Jan 2, 2024
@runleonarun runleonarun mentioned this issue Jan 18, 2024
Closed
1 task
@runleonarun
Copy link
Collaborator

Note there's also info in this duplicate issue

@matthewshaver matthewshaver self-assigned this Jan 18, 2024
@matthewshaver matthewshaver mentioned this issue Jan 18, 2024
Merged
3 tasks
matthewshaver added a commit that referenced this issue Jan 19, 2024
@matthewshaver
Updating freshness ref page (#4770)
4d46b20 
## What are you changing in this pull request and why?

Updating the `freshness` ref page to include new information for v1.7

Closes #4615

## Checklist

- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [x] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewshaver matthewshaver

Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: high Technical inaccuracy, missing/incorrect information, or broken links. Negatively affects workflows size: x-small This change will take under 3 hours to fix. source freshness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating freshness ref page dbt-labs/docs.getdbt.com
4 participants
@runleonarun @dbeatty10 @graciegoheen @matthewshaver