Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop windows-gdbus feature and related hacks #687

Closed
zeenix opened this issue Mar 25, 2024 · 0 comments · Fixed by #729
Closed

Drop windows-gdbus feature and related hacks #687

zeenix opened this issue Mar 25, 2024 · 0 comments · Fixed by #729
Labels
windows Issue is specific to Windows

Comments

@zeenix
Copy link
Contributor

zeenix commented Mar 25, 2024 •
edited
Loading

The reference implementation supports autolaunch addresses so this feature or recommendation of gdbus.exe isn't required. Dropping this feature will also allow us to drop the hacks we've for it as it has many issues and limitations.
@zeenix zeenix added the windows Issue is specific to Windows label Mar 25, 2024
@zeenix zeenix mentioned this issue Apr 18, 2024
Open
zeenix added a commit to zeenix/zbus that referenced this issue Apr 22, 2024
@zeenix
🚩 zb: Support autolaunch address on Windows w/o windows-gdbus feature
0efa4d2 
Turns out that the reference dbus implementation supports autolaunch
fine and we don't need gdbus binary or special support for it.
Hopefully, in the near future, busd will also support it.

This commit drops the `windows-gdbus` feature. This means we're no longer
compatible with gdbus binary but that's not our fault that it can't handle
handshake pipelining. I seriously doubt anyone uses this anyway.

Fixes dbus2#687.
@zeenix zeenix mentioned this issue Apr 22, 2024
Merged
@zeenix zeenix changed the title Drop gdbus workarounds in favor of busd Drop windows-gdbus feature and related hacks Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows Issue is specific to Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔥 zb: Drop windows-gdbus feature & support autolaunch address unconditionally zeenix/zbus
1 participant
@zeenix