"rendersize" changed to "tilerendersize" in TmxReaderBase.Tileset.cs #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation updates
Release v0.2.1
To match XML property. Seems to be correct elsewhere.
|
Added a CustomEnumStorageType to the FromEnum method. Defaulting to .Int here tripped me up pretty good. Parametrizing this here will make people's lives easier. I think defaulting to .String is a good idea also since that is the default in the Tiled Custom Types Editor for enums, but I will leave this to your discretion. |
Able to get string of value without knowing the property type. It is generated for all values except EnumProperty, where it is set at construction. Ideally, all should be set at construction so it is 1:1 with the XML, but there are too many places to update, and generating the string is good enough. Also in this commit: OverrideObject stack overflow bug fixed. Unsure what the original recursive structure was for.
When an unset Color property was parsed, an exception was thrown. This exception was moved into TryParse. Now, the Color can be null.
differenceclouds
force-pushed
the
dev
branch
from
8f375a6
to
c83c8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"rendersize" changed to "tilerendersize" in TmxReaderBase.Tileset.cs to match XML property. Seems to be correct elsewhere. I'm not a big PR'er, so unsure if I've done it correctly. Thanks for the awesome library!