This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
HTTP endpoint used in tests changed #81
Assignees
Comments
radu-matei
added a commit
to radu-matei/wasi-experimental-http
that referenced
this issue
Jan 9, 2022
This commit updates the expected response body from https://api.brigade.sh/healthz to be an empty response. This partially addresses deislabs#81 by fixing the failing tests, but the larger issue remains — finding a test endpoint we could use to properly test the response body. Signed-off-by: Radu Matei <radu.matei@fermyon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The tests are currently failing because the endpoint we have been using in our tests — https://api.brigade.sh/healthz no longer returns
"OK"(but an empty response).In order for the tests to pass, we either need to update the tests to check for an empty response (which is not ideal, because it does not actually check that the response body is handled correctly), or test a different endpoint.
Any ideas?
I will probably put out a PR to fix the failing tests by updating the expected body, but we should find an endpoint that actually helps test the response body properly.
The text was updated successfully, but these errors were encountered: