Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets fail due to missing pong #7231

Closed
mschwartz opened this issue Aug 28, 2020 · 3 comments
Closed

WebSockets fail due to missing pong #7231

mschwartz opened this issue Aug 28, 2020 · 3 comments

Comments

@mschwartz
Copy link

ryo-ma/deno-websocket#5 (comment)

See issue in the WebSocket repository.
@ribizli
Copy link

ribizli commented Sep 12, 2020

The original error tells Client MUST mask all frames (RFC-6455: Section 5.1).

https://deno.land/std@0.68.0/ws/mod.ts#L272-L279

The code above missing the mask from the frame, I guess this could be the issue.

@bartlomieju
Copy link
Member

WebSocket client landed in #7051 which will be available in 1.4.0 on Sunday. We've also deprecated client in std/ws/.

@ryo-ma ryo-ma mentioned this issue Sep 20, 2020
Open
@bartlomieju
Copy link
Member

I think this issue is no longer relevant given WebSocket API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mschwartz @ribizli @bartlomieju