-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collections): support Iterable
argument in slidingWindows()
#5916
Draft
Liam-Tait
wants to merge
7
commits into
denoland:main
Choose a base branch
from
Liam-Tait:liam/iterable-slidingWindows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liam-Tait
force-pushed
the
liam/iterable-slidingWindows
branch
from
September 5, 2024 09:44
15642f9
to
2bc1f69
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5916 +/- ##
=======================================
Coverage 96.25% 96.26%
=======================================
Files 489 489
Lines 39457 39499 +42
Branches 5824 5839 +15
=======================================
+ Hits 37980 38022 +42
Misses 1433 1433
Partials 44 44 ☔ View full report in Codecov by Sentry. |
Liam-Tait
changed the title
feat(collections): support
feat(collections): support Sep 5, 2024
Iterable
input in slidingWindows()
Iterable
argument in slidingWindows()
On second thought, Added comment to the tracking issue to discuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
Iterable
for collectionsslidingWindows
Maintains the current sliding windows for Arrays for the empty Array case. Using the iterable version would change the output from an empty array causing the case is covered by the "slidingWindows() handles empty Array" test to fail.
Example:
If the array specific implementation was removed, this would become a breaking change
With an infinite iterator this function would never return.
I added a
maxWindows
option that limits the number of windows created which would be useful to prevent that case. (maybe it should throw instead?)However I can remove if we think a seperate
take
function is betteror the onus is on the user
e.g
#5470