Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable test:browser task in CI #6070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Sep 27, 2024

No description provided.

@iuioiua iuioiua requested a review from kt3k as a code owner September 27, 2024 02:36
@iuioiua iuioiua enabled auto-merge (squash) September 27, 2024 02:36
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (2774a07) to head (8f8e701).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6070      +/-   ##
==========================================
+ Coverage   96.69%   96.71%   +0.01%     
==========================================
  Files         508      508              
  Lines       39106    39106              
  Branches     5786     5786              
==========================================
+ Hits        37814    37820       +6     
+ Misses       1250     1244       -6     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Sep 27, 2024

I think this is blocked by denoland/deno#25847

It currently passes because we published @std/internal@1.0.4 and the difference between the published packages and local packages was removed. I think the same error will happen when someone added a new entrypoint in any package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants