-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine Updates – custom docker images #44
Comments
Would it be possible to allow configuring a regexp per repo which would help you extracting that version info? In our example we're using a custom version of the alpine based ruby base-images hosted on a internal docker registry:
A (very naive) regex in that case might then be just:
IMHO this should be totally ok. One will still need to make sure the ruby version is available on all the target platforms anyways before merging the PR (assuming it's done manually). For example it also takes some time to have the ruby version available on:
|
We have similar issue we build our own images. Everytime depfu is trying to update images but in the wrong way: - FROM org/ruby:3.3.5-fdafb4d8867a42b761dc196f67526e7682d12ec9
+ FROM org/ruby:3.3.6-fdafb4d8867a42b761dc196f67526e7682d12ec9 But it should be - FROM org/ruby:3.3.5-fdafb4d8867a42b761dc196f67526e7682d12ec9
+ FROM org/ruby:3.3.6-<completly-new-sha-fetched-for-our-docker-registry> But we migrate to a new tag |
We know that quite a few teams are using custom docker images as their base image, for example like this
This makes it basically impossible for us to automatically detect that we need to update that image in the Dockerfile, since there is no relation to the ruby/nodejs version. But it also depends on someone updating the actual image to pull in the new version, so even if we would detect it, there are some workflow dependencies which make this quite tricky.
This is a known issue we're thinking about, but haven't really come up with a good solution yet. if you have any ideas, please let us know!
The text was updated successfully, but these errors were encountered: