-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't apply plugins to worker #87
Comments
[EDIT] Nevermind; regarding the Still; would it be nice to have configurable plugins for just the worker context? |
@rjgotten yes, configurable plugins would be nice. I implemented that feature in worker-plugin, and folks seem to use it. The trick with |
That's actually not that hard to solve with a general purpose |
@rjgotten that Gist looks good - want to PR it here? It could be exported as |
Currently there is no way to pass plugins to workerize-loader.
Webpack's documentation is wrong when it states that child compilers inherit all hooks and plugins from the parent compiler. They infact do not inherit plugins at all; they copy over a number of hooks from the parent compiler -- where some plugins may have added them -- to the child compiler.
Several hooks are blacklisted. Banned from this copy process are:
make
,compile
,emit
,afterEmit
,invalid
,done
, andthisCompilation
. There are ofcourse good reasons not to copy those hooks - as doing so would mess with the control flow for the child compilation and parent compilation. However, it does mean the child compiler has to be fed its own instances of plugins such as theCompressionPlugin
which attach to those hooks.https://github.com/webpack/webpack/blob/498bb0841bd79476569701dc2e4f0f65dc87359c/lib/Compiler.js#L773-L846
This is what the third
plugins
argument to thecreateChildCompiler
method is for, but having a look at how the child compiler that creates the body of the worker is called:workerize-loader/src/index.js
Line 59 in 2688667
it doesn't link up that third parameter. So right now there is no well-defined way to e.g. apply
CompressionPlugin
and get Gzip or Brotli compressed workers.It may still be possible to achieve this by tapping the
childCompiler
hook on the parent compilation, as it does get passed the created child compiler.This requires people write their own custom "plugin to apply plugins" - which is well beyond the comfort zone of most Webpack users. (Most webpack users don't write their own plugins. That's something you typically only do if you really; really know what you're doing. )
It's also not exactly trivial to get right, as you'd still also need to filter by the child compiler's name to ensure they're only adding plugins to the correct child compilers created by the workerize-loader and not to e.g. those created by the MiniCssExtractPlugin. Making this worse is the fact that those child compiler names are internal implementation details and not part of any public API, i.e. are subject to change over time.
I.e. this is a short-term workaround at best.
The text was updated successfully, but these errors were encountered: