Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow additional database options #426

Open
dale-wahl opened this issue Apr 16, 2024 · 0 comments
Open

Feature request: allow additional database options #426

dale-wahl opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dale-wahl
Copy link
Member

It ought to be possible to allow further configuration of database connections (a PR was proposed but needed additional work #285). Instead of individual parameters being stored in the .env file and config.ini file, psql allows strings to be passed.

E.g. psql --host=$POSTGRES_HOST --port=$POSTGRES_PORT --user=$POSTGRES_USER --dbname=$POSTGRES_DB becomes psql "host=$POSTGRES_HOST port=$POSTGRES_PORT user=$POSTGRES_USER password=$POSTGRES_PASSWORD dbname=$POSTGRES_DB".

To make that change, it would have to work with both psql in files like docker/docker-entrypoint.sh as well as with our Database class. And the string would need to be passed via docker/docker_setup.py to the [https://github.com/digitalmethodsinitiative/4cat/blob/master/common/config_manager.py](config manager).

Opening this issue to track any need/interest of such a feature.

@dale-wahl dale-wahl added the enhancement New feature or request label Apr 16, 2024
@dale-wahl dale-wahl self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant