Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matching context of our most important bubble : Alternatives to Amazon books #467

Open
MaartenLMEM opened this issue Nov 22, 2021 · 0 comments
Open

Fix matching context of our most important bubble : Alternatives to Amazon books #467

MaartenLMEM opened this issue Nov 22, 2021 · 0 comments
Assignees
@JalilArfaoui @gregoirelacoste

Comments

@MaartenLMEM
Copy link
Contributor

MaartenLMEM commented Nov 22, 2021 •
edited
Loading

Bubble n° 2019 is no more displayed since beginning of october 2021.
Cause : Amazon website probably changed its product page structure.

To do :

  1. Fix xpath - Grégoire (or Jalil)
  2. Make an rescue regex in case it is down - Maarten

Link to the notice : https://notices.lmem.net/admin/?action=edit&entity=Notice&menuIndex=&submenuIndex=&query=2019&sortField=id&sortDirection=DESC&page=1&referer=%252Fadmin%252F%253Faction%253Dsearch%2526entity%253DNotice%2526menuIndex%253D%2526submenuIndex%253D%2526query%253D2019%2526sortField%253Did%2526sortDirection%253DDESC%2526page%253D1&id=2019
@MaartenLMEM MaartenLMEM changed the title Fix matching context of our most important bubble : Alterantives to Amazon books Fix matching context of our most important bubble : Alternatives to Amazon books Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JalilArfaoui JalilArfaoui

@gregoirelacoste gregoirelacoste

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JalilArfaoui @MaartenLMEM @gregoirelacoste