Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability: Communication between CLI and 3D on an unencrypted connection #223

Open
FrancoLiberali opened this issue Sep 26, 2023 · 0 comments
Labels
Bug Something isn't working CLI

Comments

@FrancoLiberali
Copy link
Collaborator

When the CLI establishes connection with the 3D it sends a first message containing the API url and the JWT used for authentication, which the CLI obtained when logging in with the username and password. Since this communication is via a tcp socket, it is not encrypted. Therefore, this secret token can be easily read by another process, for example, it can be seen using Wireshark:

image

Furthermore, the CLI does not perform any verification of which process it sends this information to, any process that accepts a connection on the correct port can receive it, for example a malicious process that is looking for this information in order to make API calls on behalf of the user.

To solve this we could:

  1. Transmit this information via a secure (encrypted) channel and where it is actually verified that the information is sent to an Ogree-3d process (complicated)
  2. Have Ogree-3d do its own authentication, avoiding the need to transmit the token

This same problem actually applies to all information that the CLI transmits to the 3D, so a malicious process could retrieve information of the datacenter

@FrancoLiberali FrancoLiberali added Bug Something isn't working CLI labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working CLI
Projects
None yet
Development

No branches or pull requests

1 participant