Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose version and user agent to consumers #158

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: expose version and user agent to consumers #158

merged 1 commit into from
Sep 9, 2024

Conversation

kipz
Copy link
Contributor

@kipz kipz commented Sep 9, 2024

#157 introduced user agent support, but hid it all in the internal folder 🤦🏿

This exposes that stuff for library consumers to get the attest version and get/set the user agent string on the context

@kipz kipz requested a review from a team as a code owner September 9, 2024 16:59
@github-actions github-actions bot added the bug Something isn't working label Sep 9, 2024
@kipz kipz enabled auto-merge (squash) September 9, 2024 17:00
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.17%. Comparing base (b4e6767) to head (9736bfd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          41       41           
  Lines        2423     2423           
=======================================
  Hits         1652     1652           
  Misses        495      495           
  Partials      276      276           
Flag Coverage Δ
unittests 68.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kipz kipz merged commit 206b33c into main Sep 9, 2024
7 checks passed
@kipz kipz deleted the kipz_pkg branch September 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants