Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regexes for autolabeler #160

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix: regexes for autolabeler #160

merged 2 commits into from
Sep 10, 2024

Conversation

jonnystoten
Copy link
Contributor

☝️ had the bug label added because the title contains "fix" in the word "prefix"

@jonnystoten jonnystoten requested a review from a team as a code owner September 10, 2024 15:41
@github-actions github-actions bot added the bug Something isn't working label Sep 10, 2024
@jonnystoten jonnystoten changed the title Fix regexes for autolabeler fix: regexes for autolabeler Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.24%. Comparing base (206b33c) to head (a0c7bb2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   68.17%   68.24%   +0.06%     
==========================================
  Files          41       41              
  Lines        2423     2428       +5     
==========================================
+ Hits         1652     1657       +5     
  Misses        495      495              
  Partials      276      276              
Flag Coverage Δ
unittests 68.24% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branches need not be similarly anchored?

@jonnystoten
Copy link
Contributor Author

It looks as though nobody really uses the branch prefixes. I'll remove them.

Copy link
Contributor

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@jonnystoten jonnystoten merged commit 6022954 into main Sep 10, 2024
9 checks passed
@jonnystoten jonnystoten deleted the fix-autolabeler-regex branch September 10, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants