Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce timeout keepalive timeout for connections with buildkit agents #2770

Open
droopy4096 opened this issue Oct 31, 2024 · 0 comments
Open
Labels
kind/enhancement New feature or request status/triage

Comments

@droopy4096
Copy link
Contributor

Description

Narrowing the scope of #1923 to a smaller change:

in our pipelines, while building larger images we experience occasional network interruptions in connections between buildx and buildkit which results in a "stale" connection where buildx waits for an undefined period of time (it times out due to our CI jobs having time limit) . Having a parameter to define wait time could help to detect broken connections sooner and retry rather than waiting indefinite amount of time for it to eventually fail and then retry.

To clarify - we could shorten timeouts for our jobs, but those timeouts cover the actual build and it can legitimately stretch for the entire duration of a timeout. However it's impossible from pipeline (or any scripting, really) perspective to distinguish between ongoing build and stale connection. Thus adding a timeout where we can state that "buildx is to give up connection with buildkit if there were no network exchange between the two for at least X minutes".

@droopy4096 droopy4096 added kind/enhancement New feature or request status/triage labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request status/triage
Projects
None yet
Development

No branches or pull requests

1 participant