Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd.io package naming is missing the distribution #303

Open
devopstt opened this issue Jan 2, 2023 · 2 comments
Open

containerd.io package naming is missing the distribution #303

devopstt opened this issue Jan 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@devopstt
Copy link

devopstt commented Jan 2, 2023

Hi,

we are using APTLY to mirror download.docker.com to our internal APT mirror.
Recently we ran into this issue aptly-dev/aptly#1036

The error we got:

ERROR: unable to publish: unable to process packages: error linking file to /opt/mirror/public/3rdparty/2022-03-15/pool/main/c/containerd.io/containerd.io_1.5.10-1_amd64.deb: file already exists and is different

The files are indeed different but have the same name for bionic and focal (same for jammy and all other releases).
https://download.docker.com/linux/ubuntu/dists/focal/pool/stable/amd64/containerd.io_1.5.10-1_amd64.deb
https://download.docker.com/linux/ubuntu/dists/bionic/pool/stable/amd64/containerd.io_1.5.10-1_amd64.deb

The package name does not inlcude the debian_revision what leads to duplicate package names.

For all the other packages the naming is fine, like for docker-ce-cli, because it includes the debian_revision

docker-ce-cli_20.10.13~3-0~ubuntu-jammy_amd64.deb

https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-version
As it is recommended by Debian to add the debian_revision, could you add it to future releases, please?

@thaJeztah
Copy link
Member

Thanks for reporting; this is similar to / related to docker/for-linux#1315

I noticed this as well, and we probably need changes similar to docker/docker-ce-packaging#701 (docker/docker-ce-packaging@f8299f2) for the containerd packages as well.

the build-scripts for containerd packages are in a separate repository (https://github.com/docker/containerd-packaging); let me transfer this ticket to that repository's issue tracker.

@tirolerstefan
Copy link

Hi @thaJeztah - thanks for linking my issue "Different checksum..." to this project.
Do you roughly know when this could be implemented? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants