Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close on Queue cannot close downstream #23

Open
stevvooe opened this issue Jul 27, 2017 · 1 comment
Open

Close on Queue cannot close downstream #23

stevvooe opened this issue Jul 27, 2017 · 1 comment

Comments

@stevvooe
Copy link
Contributor

If you have a Queue writing to a Channel and call close on the Queue, Queue.Close will block on writing to Channel.Write. This is because the Close waits on the shutdown condition of the Queue.

Please see containerd/containerd#1254 for the mitigation for this.

@Adirio
Copy link

Adirio commented May 3, 2018

Should queues be able to drop the held messages when stopped if configured to do so? I mean, use an additional parameter that instructs the queues to drop their messages either instantly or after some time when they are closed so that the next sink in the pipeline can be closed in a "time-deterministic" fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants