Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding same note multiple times #4

Open
reefdog opened this issue May 5, 2015 · 0 comments
Open

Embedding same note multiple times #4

reefdog opened this issue May 5, 2015 · 0 comments
Labels

Comments

@reefdog
Copy link
Contributor

reefdog commented May 5, 2015

Sprung from: documentcloud/documentcloud#19

Been chatting with @knowtheory about ways to allow this. Basically, we should be able to internally store a note model once and then reference it from multiple note views. Currently, there's a 1:1 relationship and so the last view instantiated is the only one who gets the note. (dc.embed.notes is keyed by note ID and points to a noteView, so you can't have multiple noteViews modeled on the same note.)

Goals:

  1. Make this work
  2. Make this work in a way that doesn't break existing integrations

Classifying this as a bug because there are many reasonably scenarios where a user would expect the same note to appear on the same page (e.g., index page for blog posts which each embed the same note).

@reefdog reefdog added the bug label May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant