Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew formula: tools/clang/scripts/update.py is missing #7

Open
jpmckinney opened this issue Dec 28, 2015 · 3 comments
Open

Homebrew formula: tools/clang/scripts/update.py is missing #7

jpmckinney opened this issue Dec 28, 2015 · 3 comments

Comments

@jpmckinney
Copy link

I'm seeing the following error:

build/gyp_pdfium

Updating projects from gyp files...
/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python: can't open file '../tools/clang/scripts/update.py': [Errno 2] No such file or directory
gyp: Call to 'python ../tools/clang/scripts/update.py --print-revision' returned exit status 2 while in /private/tmp/pdfium20151228-46857-htvxjl/build/all.gyp.

I'm not sure how to get tools/clang/scripts/update.py. Googling didn't turn up any clear fix.

@jpmckinney
Copy link
Author

It's missing because a simple git clone of https://pdfium.googlesource.com/pdfium (as in the formula) won't download any files to tools/clang. If you get the depot_tools and run:

mkdir repo
cd repo
gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git
gclient sync
cd pdfium

Then tools/clang/scripts/update.py is written.

@jpmckinney
Copy link
Author

See https://github.com/knowtheory/homebrew/pull/1 for a one-line fix.

@knowtheory
Copy link
Member

Thanks @jpmckinney! I've got an automated test build in mind for this, but haven't had time to get anything implemented yet :\

PDFium very much follows the chromium model of development, so they seem to happily rearrange all manner of things in the repo (dependencies, build output layout, internal organization, etc).

It's kind of a bummer because installing the depot tools requires changes to one's env, which is why i've decomposed the deps at a particular point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants