Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sort mode broken, when canceling with <ctrl+s> instead of <esc> #175

Closed
LanceTheDev opened this issue Mar 15, 2024 · 7 comments
Closed
Labels
bug Something isn't working

Comments

@LanceTheDev
Copy link

Describe the bug 🐛
When I cancel the sort mode with <ctrl+s> instead of key, it's not toggleable anymore afterwards. I need to restart the application to make it work again.

To Reproduce 🐣

  1. Open sort menu by pressing <ctrl+s>
  2. Cancel sort menu by pressing <ctrl+s> instead of
  3. Menu closes, but mode stays is "SORT"

Expected behavior 🤔
Mode should switch back to NORMAL and sort menu should be toggleable afterwards

Desktop (please complete the following information): 🤖

  • OS: Ubuntu 22.04.3 LTS
  • Version: 2.2.0
@LanceTheDev LanceTheDev added the bug Something isn't working label Mar 15, 2024
@kraanzu
Copy link
Member

kraanzu commented Mar 15, 2024

It's weird behavior indeed. Fortunately escape works.
I'll look into this

@LanceTheDev
Copy link
Author

LanceTheDev commented Mar 15, 2024

I would like to take a look into that issue as well. I believe my python skills should at least be good enough to identify the root cause. If you agree, I will take a look into it the coming days and report back.

@kraanzu
Copy link
Member

kraanzu commented Mar 15, 2024

Sure thing. The code might be a bit messy (I'm planning on a re-work) so feel free to ping me for any pointers

@LanceTheDev
Copy link
Author

I haven't had the time yet, to tackle this and wanted to reaffirm you of my willingness to do so. Next week, starting on wednesday, I will take a few days off of work and will make sure, to start with it 👍

@kraanzu
Copy link
Member

kraanzu commented Mar 26, 2024

Thanks for the confirmation! Do give me a heads up if you start with anything :)

I will take a few days off of work and will make sure, to start with it 👍

Ay! Don't stress too much about it man. And days off are for relaxing 😎

@kraanzu
Copy link
Member

kraanzu commented Nov 10, 2024

Closing this as stale, escape is now the only key to close sort menu :)

@kraanzu kraanzu closed this as completed Nov 10, 2024
Copy link

Did we solve your problem?
Glad we could help!

Consider sponsoring my work through github sponsors 😄
@kraanzu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants